From 7fe37b8666d2de1b8c010d3550fa2fa641826d86 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Mon, 25 Jun 2018 11:14:00 -0700 Subject: [PATCH] scripts/check_format: warn if not checking Python The astyle check warns if it is missing; we should do the same for pycodestyle so that the user is aware that some checks are being skipped. Change-Id: I0709a2acaab7bcb5184e7f302d37822a124d6769 Signed-off-by: Daniel Verkamp Reviewed-on: https://review.gerrithub.io/416761 Tested-by: SPDK Automated Test System Reviewed-by: Tomasz Zawadzki Reviewed-by: Shuhei Matsumoto Reviewed-by: Ben Walker --- scripts/check_format.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/check_format.sh b/scripts/check_format.sh index 21a34e2c8..b0ca3410b 100755 --- a/scripts/check_format.sh +++ b/scripts/check_format.sh @@ -131,6 +131,8 @@ if [ ! -z ${PEP8} ]; then echo " OK" fi rm -f pep8.log +else + echo "You do not have pycodestyle or pep8 installed so your Python style is not being checked!" fi # Check if any of the public interfaces were modified by this patch.