From 7fe285565147d5fa4d72d3295a9f78bd1303d694 Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Tue, 12 Jun 2018 09:02:00 -0700 Subject: [PATCH] bdev: check desc->write in spdk_bdev_write_zeores_blocks We should not allow write_zeroes commands if the descriptor was not opened for writing. Signed-off-by: Jim Harris Change-Id: I56bc729d12089df90637b202dfe25f5505e9b712 Reviewed-on: https://review.gerrithub.io/414896 Tested-by: SPDK Automated Test System Reviewed-by: Ben Walker Reviewed-by: Shuhei Matsumoto Reviewed-by: Daniel Verkamp --- lib/bdev/bdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/bdev/bdev.c b/lib/bdev/bdev.c index 834c411df..67d3fb36d 100644 --- a/lib/bdev/bdev.c +++ b/lib/bdev/bdev.c @@ -1818,6 +1818,10 @@ spdk_bdev_write_zeroes_blocks(struct spdk_bdev_desc *desc, struct spdk_io_channe uint64_t len; bool split_request = false; + if (!desc->write) { + return -EBADF; + } + if (!spdk_bdev_io_valid_blocks(bdev, offset_blocks, num_blocks)) { return -EINVAL; }