From 7b74274fbf0cbc17b356ae3c8187466014237fad Mon Sep 17 00:00:00 2001 From: Changpeng Liu Date: Mon, 8 Jul 2019 04:21:20 -0400 Subject: [PATCH] nvmf: add parameter check when loading reservation information from a JSON file Change-Id: Id217212fd82e57a4cfb32f62f11798c72187879e Signed-off-by: Changpeng Liu Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/460794 Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Shuhei Matsumoto --- lib/nvmf/subsystem.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/nvmf/subsystem.c b/lib/nvmf/subsystem.c index 7be264524..f5b6c7cc4 100644 --- a/lib/nvmf/subsystem.c +++ b/lib/nvmf/subsystem.c @@ -1459,6 +1459,12 @@ spdk_nvmf_ns_load_reservation(const char *file, struct spdk_nvmf_reservation_inf goto exit; } + if (res.regs.num_regs > SPDK_NVMF_MAX_NUM_REGISTRANTS) { + SPDK_ERRLOG("Can only support up to %u registrants\n", SPDK_NVMF_MAX_NUM_REGISTRANTS); + rc = -ERANGE; + goto exit; + } + rc = 0; info->ptpl_activated = res.ptpl_activated; info->rtype = res.rtype;