From 7aed75fbc2755448c534c6840448fbcda7650727 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Fri, 30 Jul 2021 06:32:36 -0400 Subject: [PATCH] test/nvme_cuse: start nvme_cuse ctrlr in test_nvme_cuse_stop() Patch below broke the UT due to not accouting for changes in nvme_cuse since original submission: (19f0bfd) test/nvme_cuse: cases for stop cuse The change was introduced with: (d651f8a) nvme/nvme_cuse: Fix race condition in cuse session Now when initalizing nvme_cuse controller it uses is_started, to avoid race condition. The UT was missing this part of nvme_cuse controller initalization. Signed-off-by: Tomasz Zawadzki Change-Id: I46344977204c3383d8f400c80bc7df50e6d7581d Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9001 Reviewed-by: Michal Berger Tested-by: SPDK CI Jenkins --- test/unit/lib/nvme/nvme_cuse.c/nvme_cuse_ut.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/lib/nvme/nvme_cuse.c/nvme_cuse_ut.c b/test/unit/lib/nvme/nvme_cuse.c/nvme_cuse_ut.c index 47a891350..f11e44e82 100644 --- a/test/unit/lib/nvme/nvme_cuse.c/nvme_cuse_ut.c +++ b/test/unit/lib/nvme/nvme_cuse.c/nvme_cuse_ut.c @@ -363,6 +363,7 @@ test_nvme_cuse_stop(void) g_ctrlr_started = spdk_bit_array_create(128); SPDK_CU_ASSERT_FATAL(g_ctrlr_started != NULL); + ctrlr_device->is_started = true; ctrlr_device->ns_devices[0].is_started = true; ctrlr_device->ns_devices[1].is_started = true;