ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/virtio: remove __rte_unused annotations

Browse Source 
These are just noise, since we don't enable the unused parameter
warning.

Also remove an unused variable, txvq, in virtio_dev_start() that
had been left behind since it was marked as __rte_unused.

Change-Id: I7bda85ef5f2208dd36d8f1806d8241a04b893123
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/382494
Reviewed-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
This commit is contained in:
Daniel Verkamp 2017-10-13 12:48:48 -07:00 committed by Jim Harris
parent c32510daa8
commit 7aa53faabd
3 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/bdev/virtio/rte_virtio/virtio_dev.c
View File

@ -307,8 +307,6 @@ virtio_dev_free(struct virtio_dev *dev)
int int
virtio_dev_start(struct virtio_dev *vdev) virtio_dev_start(struct virtio_dev *vdev)
{ {
struct virtnet_tx *txvq __rte_unused;
/* Enable uio/vfio intr/eventfd mapping: althrough we already did that /* Enable uio/vfio intr/eventfd mapping: althrough we already did that
* in device configure, but it could be unmapped when device is * in device configure, but it could be unmapped when device is
* stopped. * stopped.

2
lib/bdev/virtio/rte_virtio/virtio_pci.c
View File

@ -445,7 +445,7 @@ modern_del_queue(struct virtio_dev *dev, struct virtqueue *vq)
} }
static void static void
modern_notify_queue(struct virtio_dev *dev __rte_unused, struct virtqueue *vq) modern_notify_queue(struct virtio_dev *dev, struct virtqueue *vq)
{ {
spdk_mmio_write_2(vq->notify_addr, vq->vq_queue_index); spdk_mmio_write_2(vq->notify_addr, vq->vq_queue_index);
} }

12
lib/bdev/virtio/rte_virtio/virtio_user.c
View File

@ -122,7 +122,7 @@ virtio_user_set_features(struct virtio_dev *vdev, uint64_t features)
} }
static uint8_t static uint8_t
virtio_user_get_isr(struct virtio_dev *vdev __rte_unused) virtio_user_get_isr(struct virtio_dev *vdev)
{ {
/* rxq interrupts and config interrupt are separated in virtio-user, /* rxq interrupts and config interrupt are separated in virtio-user,
* here we only report config change. * here we only report config change.
@ -131,15 +131,15 @@ virtio_user_get_isr(struct virtio_dev *vdev __rte_unused)
} }
static uint16_t static uint16_t
virtio_user_set_config_irq(struct virtio_dev *vdev __rte_unused, virtio_user_set_config_irq(struct virtio_dev *vdev,
uint16_t vec __rte_unused) uint16_t vec)
{ {
return 0; return 0;
} }
static uint16_t static uint16_t
virtio_user_set_queue_irq(struct virtio_dev *vdev __rte_unused, virtio_user_set_queue_irq(struct virtio_dev *vdev,
struct virtqueue *vq __rte_unused, struct virtqueue *vq,
uint16_t vec) uint16_t vec)
{ {
/* pretend we have done that */ /* pretend we have done that */
@ -151,7 +151,7 @@ virtio_user_set_queue_irq(struct virtio_dev *vdev __rte_unused,
* max supported queues. * max supported queues.
*/ */
static uint16_t static uint16_t
virtio_user_get_queue_num(struct virtio_dev *vdev, uint16_t queue_id __rte_unused) virtio_user_get_queue_num(struct virtio_dev *vdev, uint16_t queue_id)
{ {
struct virtio_user_dev *dev = virtio_dev_get_user_dev(vdev); struct virtio_user_dev *dev = virtio_dev_get_user_dev(vdev);