ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

app: rename traceflag cmdline option to logflag

Browse Source 
Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I2cc4e486f110bb860affc3ee4c66264813c72719

Reviewed-on: https://review.gerrithub.io/435346
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Xiaodong Liu <xiaodong.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
This commit is contained in:
Jim Harris 2018-11-27 00:50:57 -07:00
parent 870b0e5b29
commit 799aa686aa
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/applications.md
View File

@ -45,7 +45,7 @@ Param | Long Param | Type | Default | Descript
-W | --pci-whitelist | B:D:F | | @ref cmd_arg_pci_blacklist_whitelist. -W | --pci-whitelist | B:D:F | | @ref cmd_arg_pci_blacklist_whitelist.
-R | --huge-unlink | flag | | @ref cmd_arg_huge_unlink -R | --huge-unlink | flag | | @ref cmd_arg_huge_unlink
| | --huge-dir | string | the first discovered | allocate hugepages from a specific mount | | --huge-dir | string | the first discovered | allocate hugepages from a specific mount
-L | --traceflag | string | | @ref cmd_arg_debug_log_flags -L | --logflag | string | | @ref cmd_arg_debug_log_flags
### Configuration file {#cmd_arg_config_file} ### Configuration file {#cmd_arg_config_file}
@ -141,7 +141,7 @@ process as soon as they're created, but is not compatible with `--shm-id`.
### Debug log {#cmd_arg_debug_log_flags} ### Debug log {#cmd_arg_debug_log_flags}
Enable a specific debug log type. This option can be used more than once. A list of Enable a specific debug log type. This option can be used more than once. A list of
all available types is provided in the `--help` output, with `--traceflag all` all available types is provided in the `--help` output, with `--logflag all`
enabling all of them. Debug logs are only available in debug builds of SPDK. enabling all of them. Debug logs are only available in debug builds of SPDK.
## CPU mask {#cpu_mask} ## CPU mask {#cpu_mask}

6
lib/event/app.c
View File

@ -104,8 +104,8 @@ static const struct option g_cmdline_options[] = {
{"no-pci", no_argument, NULL, NO_PCI_OPT_IDX}, {"no-pci", no_argument, NULL, NO_PCI_OPT_IDX},
#define PCI_BLACKLIST_OPT_IDX 'B' #define PCI_BLACKLIST_OPT_IDX 'B'
{"pci-blacklist", required_argument, NULL, PCI_BLACKLIST_OPT_IDX}, {"pci-blacklist", required_argument, NULL, PCI_BLACKLIST_OPT_IDX},
#define TRACEFLAG_OPT_IDX 'L' #define LOGFLAG_OPT_IDX 'L'
{"traceflag", required_argument, NULL, TRACEFLAG_OPT_IDX}, {"logflag", required_argument, NULL, LOGFLAG_OPT_IDX},
#define HUGE_UNLINK_OPT_IDX 'R' #define HUGE_UNLINK_OPT_IDX 'R'
{"huge-unlink", no_argument, NULL, HUGE_UNLINK_OPT_IDX}, {"huge-unlink", no_argument, NULL, HUGE_UNLINK_OPT_IDX},
#define PCI_WHITELIST_OPT_IDX 'W' #define PCI_WHITELIST_OPT_IDX 'W'
@ -896,7 +896,7 @@ spdk_app_parse_args(int argc, char **argv, struct spdk_app_opts *opts,
goto out; goto out;
} }
break; break;
case TRACEFLAG_OPT_IDX: case LOGFLAG_OPT_IDX:
#ifndef DEBUG #ifndef DEBUG
fprintf(stderr, "%s must be built with CONFIG_DEBUG=y for -L flag\n", fprintf(stderr, "%s must be built with CONFIG_DEBUG=y for -L flag\n",
argv[0]); argv[0]);

4
lib/log/log_flags.c
View File

@ -188,7 +188,7 @@ spdk_log_usage(FILE *f, const char *log_arg)
{ {
#ifdef DEBUG #ifdef DEBUG
struct spdk_log_flag *flag; struct spdk_log_flag *flag;
fprintf(f, " %s, --traceflag <flag> enable debug log flag (all", log_arg); fprintf(f, " %s, --logflag <flag> enable debug log flag (all", log_arg);
TAILQ_FOREACH(flag, &g_log_flags, tailq) { TAILQ_FOREACH(flag, &g_log_flags, tailq) {
fprintf(f, ", %s", flag->name); fprintf(f, ", %s", flag->name);
@ -196,7 +196,7 @@ spdk_log_usage(FILE *f, const char *log_arg)
fprintf(f, ")\n"); fprintf(f, ")\n");
#else #else
fprintf(f, " %s, --traceflag <flag> enable debug log flag (not supported" fprintf(f, " %s, --logflag <flag> enable debug log flag (not supported"
" - must rebuild with --enable-debug)\n", log_arg); " - must rebuild with --enable-debug)\n", log_arg);
#endif #endif
} }