From 75a6265de9b281ba1ff010e2d30657ad1239a681 Mon Sep 17 00:00:00 2001
From: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Date: Tue, 21 May 2019 11:48:14 +0200
Subject: [PATCH] rpc: fix segfault on get_spdk_version request with extra
 params

We tried to send two responses for a single RPC request.

Fixes #798

Change-Id: I37eebd6a1212f6ab2c026b7587415e42c3c7417e
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455220
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
---
 lib/rpc/rpc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/rpc/rpc.c b/lib/rpc/rpc.c
index f8bb35f8b..ff20a4685 100644
--- a/lib/rpc/rpc.c
+++ b/lib/rpc/rpc.c
@@ -391,6 +391,7 @@ spdk_rpc_get_spdk_version(struct spdk_jsonrpc_request *request, const struct spd
 	if (params != NULL) {
 		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
 						 "get_spdk_version method requires no parameters");
+		return;
 	}
 
 	w = spdk_jsonrpc_begin_result(request);