From 75646dbe372606483c2b4767fcc6ebd981e121d4 Mon Sep 17 00:00:00 2001
From: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Date: Tue, 10 Jul 2018 17:18:01 +0900
Subject: [PATCH] scripts/rpc: Some params of iSCSI methods are non-optional
 against intention

Change-Id: I051af6dbba1064633722b7e3b49787213343b581
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/418784
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
---
 scripts/rpc/iscsi.py | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/scripts/rpc/iscsi.py b/scripts/rpc/iscsi.py
index 541f57868..28c755364 100755
--- a/scripts/rpc/iscsi.py
+++ b/scripts/rpc/iscsi.py
@@ -258,7 +258,12 @@ def add_initiators_to_initiator_group(
     Returns:
         True or False
     """
-    params = {'tag': tag, 'initiators': initiators, 'netmasks': netmasks}
+    params = {'tag': tag}
+
+    if initiators:
+        params['initiators'] = initiators
+    if netmasks:
+        params['netmasks'] = netmasks
     return client.call('add_initiators_to_initiator_group', params)
 
 
@@ -274,7 +279,12 @@ def delete_initiators_from_initiator_group(
     Returns:
         True or False
     """
-    params = {'tag': tag, 'initiators': initiators, 'netmasks': netmasks}
+    params = {'tag': tag}
+
+    if initiators:
+        params['initiators'] = initiators
+    if netmasks:
+        params['netmasks'] = netmasks
     return client.call('delete_initiators_from_initiator_group', params)