From 74da2fade446a86f5a42954f618b386d67bd6f1c Mon Sep 17 00:00:00 2001 From: Ziye Yang Date: Thu, 23 Mar 2017 15:44:36 +0800 Subject: [PATCH] Replace sprintf with snprintf in several files Change-Id: I2a46433e81e605e57df4b2a1a9c1c27097333d0c Signed-off-by: Ziye Yang --- lib/env_dpdk/pci.c | 5 +++-- test/lib/iscsi/target_node/target_node_ut.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/env_dpdk/pci.c b/lib/env_dpdk/pci.c index b7db73ba5..acad241c7 100644 --- a/lib/env_dpdk/pci.c +++ b/lib/env_dpdk/pci.c @@ -337,7 +337,7 @@ spdk_pci_device_get_serial_number(struct spdk_pci_device *dev, char *sn, size_t if (err) return -1; } - sprintf(sn, "%08x%08x", buf[1], buf[0]); + snprintf(sn, len, "%08x%08x", buf[1], buf[0]); return 0; } } @@ -404,7 +404,8 @@ spdk_pci_device_claim(const struct spdk_pci_addr *pci_addr) .l_len = 0, }; - sprintf(shm_name, PCI_PRI_FMT, pci_addr->domain, pci_addr->bus, pci_addr->dev, pci_addr->func); + snprintf(shm_name, sizeof(shm_name), PCI_PRI_FMT, pci_addr->domain, pci_addr->bus, pci_addr->dev, + pci_addr->func); dev_fd = shm_open(shm_name, O_RDWR | O_CREAT, 0600); if (dev_fd == -1) { diff --git a/test/lib/iscsi/target_node/target_node_ut.c b/test/lib/iscsi/target_node/target_node_ut.c index 81dc8ad6c..ca6a96331 100644 --- a/test/lib/iscsi/target_node/target_node_ut.c +++ b/test/lib/iscsi/target_node/target_node_ut.c @@ -80,7 +80,7 @@ config_file_fail_cases(void) section_index = 0; while (true) { - sprintf(section_name, "Failure%d", section_index); + snprintf(section_name, sizeof(section_name), "Failure%d", section_index); sp = spdk_conf_find_section(config, section_name); if (sp == NULL) { break;