From 743081c22b181d3ba5ce9a523ea8151a179ebf15 Mon Sep 17 00:00:00 2001 From: JinYu Date: Wed, 8 May 2019 22:26:54 +0800 Subject: [PATCH] unit/nvme: add FC and TCP in trid trtype test case. Add two trtype test and increase code coverage. Change-Id: I59543dc6aa56529b05bb7ac5717d9ba7004b8b72 Signed-off-by: JinYu Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/453626 Tested-by: SPDK CI Jenkins Reviewed-by: Seth Howell Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- test/unit/lib/nvme/nvme.c/nvme_ut.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/test/unit/lib/nvme/nvme.c/nvme_ut.c b/test/unit/lib/nvme/nvme.c/nvme_ut.c index cf4fcf172..2db54b160 100644 --- a/test/unit/lib/nvme/nvme.c/nvme_ut.c +++ b/test/unit/lib/nvme/nvme.c/nvme_ut.c @@ -956,6 +956,23 @@ test_spdk_nvme_transport_id_parse_trtype(void) spdk_nvme_transport_id_parse_trtype(trtype, str); CU_ASSERT((*trtype) == SPDK_NVME_TRANSPORT_RDMA); + /* test trtype value when use function "strcasecmp" to compare str and "FC"，not case-sensitive */ + str = "FC"; + spdk_nvme_transport_id_parse_trtype(trtype, str); + CU_ASSERT((*trtype) == SPDK_NVME_TRANSPORT_FC); + + str = "fc"; + spdk_nvme_transport_id_parse_trtype(trtype, str); + CU_ASSERT((*trtype) == SPDK_NVME_TRANSPORT_FC); + + /* test trtype value when use function "strcasecmp" to compare str and "TCP"，not case-sensitive */ + str = "TCP"; + spdk_nvme_transport_id_parse_trtype(trtype, str); + CU_ASSERT((*trtype) == SPDK_NVME_TRANSPORT_TCP); + + str = "tcp"; + spdk_nvme_transport_id_parse_trtype(trtype, str); + CU_ASSERT((*trtype) == SPDK_NVME_TRANSPORT_TCP); } static void @@ -1035,6 +1052,14 @@ test_trid_trtype_str(void) s = spdk_nvme_transport_id_trtype_str(SPDK_NVME_TRANSPORT_RDMA); SPDK_CU_ASSERT_FATAL(s != NULL); CU_ASSERT(strcmp(s, "RDMA") == 0); + + s = spdk_nvme_transport_id_trtype_str(SPDK_NVME_TRANSPORT_FC); + SPDK_CU_ASSERT_FATAL(s != NULL); + CU_ASSERT(strcmp(s, "FC") == 0); + + s = spdk_nvme_transport_id_trtype_str(SPDK_NVME_TRANSPORT_TCP); + SPDK_CU_ASSERT_FATAL(s != NULL); + CU_ASSERT(strcmp(s, "TCP") == 0); } static void