From 73de52e9aed2a002662d1f8df51980acfc291ba1 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Fri, 8 Apr 2016 09:58:44 -0700 Subject: [PATCH] nvme: add sanity checks to remove_child Change-Id: Id212700459901c3f7bb6cd2f63ba1b88a7417ac2 Signed-off-by: Daniel Verkamp --- lib/nvme/nvme_ns_cmd.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/nvme/nvme_ns_cmd.c b/lib/nvme/nvme_ns_cmd.c index ed1b722eb..9d8b79989 100644 --- a/lib/nvme/nvme_ns_cmd.c +++ b/lib/nvme/nvme_ns_cmd.c @@ -83,6 +83,11 @@ nvme_request_add_child(struct nvme_request *parent, struct nvme_request *child) void nvme_request_remove_child(struct nvme_request *parent, struct nvme_request *child) { + nvme_assert(parent != NULL, ("parent == NULL\n")); + nvme_assert(child != NULL, ("child == NULL\n")); + nvme_assert(child->parent == parent, ("child->parent != parent\n")); + nvme_assert(parent->num_children != 0, ("num_children == 0\n")); + parent->num_children--; TAILQ_REMOVE(&parent->children, child, child_tailq); }