ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/unit/nvmf: fix qid too large test

Browse Source 
We need to be checking whether the specified qid
is too large or not - the current test says it is
doing that in the comments but is really just
checking the duplicate QID path (which following
test already covers).

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I21dac3c7ec83a5c8e31fac77481708d54cb40e9e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17368
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Jim Harris 2023-03-28 11:58:44 +00:00
parent 3741a85228
commit 736e1c1be1
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/unit/lib/nvmf/ctrlr.c/ctrlr_ut.c
View File

@ -792,11 +792,9 @@ test_connect(void)
CU_ASSERT(sgroups[subsystem.id].mgmt_io_outstanding == 0); CU_ASSERT(sgroups[subsystem.id].mgmt_io_outstanding == 0);
ctrlr.vcprop.cc.bits.iocqes = 4; ctrlr.vcprop.cc.bits.iocqes = 4;
/* I/O connect with too many existing qpairs */ /* I/O connect with qid that is too large */
memset(&rsp, 0, sizeof(rsp)); memset(&rsp, 0, sizeof(rsp));
spdk_bit_array_set(ctrlr.qpair_mask, 0); cmd.connect_cmd.qid = 3;
spdk_bit_array_set(ctrlr.qpair_mask, 1);
spdk_bit_array_set(ctrlr.qpair_mask, 2);
sgroups[subsystem.id].mgmt_io_outstanding++; sgroups[subsystem.id].mgmt_io_outstanding++;
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link); TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
rc = nvmf_ctrlr_cmd_connect(&req); rc = nvmf_ctrlr_cmd_connect(&req);
@ -806,9 +804,6 @@ test_connect(void)
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER); CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER);
CU_ASSERT(qpair.ctrlr == NULL); CU_ASSERT(qpair.ctrlr == NULL);
CU_ASSERT(sgroups[subsystem.id].mgmt_io_outstanding == 0); CU_ASSERT(sgroups[subsystem.id].mgmt_io_outstanding == 0);
spdk_bit_array_clear(ctrlr.qpair_mask, 0);
spdk_bit_array_clear(ctrlr.qpair_mask, 1);
spdk_bit_array_clear(ctrlr.qpair_mask, 2);
/* I/O connect with duplicate queue ID */ /* I/O connect with duplicate queue ID */
memset(&rsp, 0, sizeof(rsp)); memset(&rsp, 0, sizeof(rsp));