ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: remove unreachable read iovec copy path

Browse Source 
The SCSI layer always passes task->iovs to spdk_bdev_readv(), so there
is no way for task->iovs != bdev_io->u.read.iovs to be true.

Change-Id: I4c0a2075c6e50e4304d62707a29bededa37b4e5c
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2017-05-04 13:18:03 -07:00 committed by Ben Walker
parent 15fcb1020c
commit 730a63d02b
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/scsi/scsi_bdev.c
View File

@ -1231,8 +1231,6 @@ spdk_bdev_scsi_task_complete(struct spdk_bdev_io *bdev_io, enum spdk_bdev_io_sta
void *cb_arg) void *cb_arg)
{ {
struct spdk_scsi_task *task = cb_arg; struct spdk_scsi_task *task = cb_arg;
struct iovec *iovs;
int iovcnt;
if (task->type == SPDK_SCSI_TASK_TYPE_CMD) { if (task->type == SPDK_SCSI_TASK_TYPE_CMD) {
int sc, sk, asc, ascq; int sc, sk, asc, ascq;
@ -1244,13 +1242,6 @@ spdk_bdev_scsi_task_complete(struct spdk_bdev_io *bdev_io, enum spdk_bdev_io_sta
task->response = SPDK_SCSI_TASK_MGMT_RESP_SUCCESS; task->response = SPDK_SCSI_TASK_MGMT_RESP_SUCCESS;
} }
spdk_bdev_io_get_iovec(bdev_io, &iovs, &iovcnt);
if (task->dxfer_dir == SPDK_SCSI_DIR_FROM_DEV && task->iovs != iovs) {
assert(iovs != NULL);
assert(task->iovcnt == iovcnt);
memcpy(task->iovs, iovs, sizeof(task->iovs[0]) * task->iovcnt);
}
spdk_scsi_lun_complete_task(task->lun, task); spdk_scsi_lun_complete_task(task->lun, task);
} }