ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/event: do not spawn a thread for each reactor

Browse Source 
Those spdk threads were neither used or tracked in event framework.

Needed to edit hardcoded cpumask value in spdkcli test to accept any string.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Ieffea1bdf467f50ec0bd3af4b17a1d259fd876b4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5817
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
This commit is contained in:
Tomasz Zawadzki 2021-01-07 08:43:56 -05:00 committed by Jim Harris
parent 229a67ad6a
commit 72eed604b4
2 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/event/reactor.c
View File

@ -811,10 +811,8 @@ void
spdk_reactors_start(void) spdk_reactors_start(void)
{ {
struct spdk_reactor *reactor; struct spdk_reactor *reactor;
struct spdk_cpuset tmp_cpumask = {};
uint32_t i, current_core; uint32_t i, current_core;
int rc; int rc;
char thread_name[32];
g_rusage_period = (CONTEXT_SWITCH_MONITOR_PERIOD * spdk_get_ticks_hz()) / SPDK_SEC_TO_USEC; g_rusage_period = (CONTEXT_SWITCH_MONITOR_PERIOD * spdk_get_ticks_hz()) / SPDK_SEC_TO_USEC;
g_reactor_state = SPDK_REACTOR_STATE_RUNNING; g_reactor_state = SPDK_REACTOR_STATE_RUNNING;
@ -833,14 +831,6 @@ spdk_reactors_start(void)
assert(false); assert(false);
return; return;
} }
/* For now, for each reactor spawn one thread. */
snprintf(thread_name, sizeof(thread_name), "reactor_%u", reactor->lcore);
spdk_cpuset_zero(&tmp_cpumask);
spdk_cpuset_set_cpu(&tmp_cpumask, i, true);
spdk_thread_create(thread_name, &tmp_cpumask);
} }
spdk_cpuset_set_cpu(&g_reactor_core_mask, i, true); spdk_cpuset_set_cpu(&g_reactor_core_mask, i, true);
} }

2
test/spdkcli/match_files/spdkcli_details_vhost_ctrl.test.match
View File

@ -14,7 +14,7 @@
} }
] ]
}, },
"cpumask": "0x3", "cpumask": "$(S)",
"ctrlr": "vhost_scsi1", "ctrlr": "vhost_scsi1",
"delay_base_us": 20, "delay_base_us": 20,
"iops_threshold": 1000000, "iops_threshold": 1000000,