From 724aa0139c8644e974cae058bc127136d2311fa4 Mon Sep 17 00:00:00 2001
From: Daniel Verkamp <daniel.verkamp@intel.com>
Date: Thu, 8 Jun 2017 09:55:21 -0700
Subject: [PATCH] iscsi: avoid use-after-free of iSCSI task

Change-Id: I29d3f856a1189fc591097488829ded8a508fbed6
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/364670
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
---
 lib/iscsi/task.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/iscsi/task.c b/lib/iscsi/task.c
index a3193a5bc..f8359ef28 100644
--- a/lib/iscsi/task.c
+++ b/lib/iscsi/task.c
@@ -45,9 +45,9 @@ spdk_iscsi_task_free(struct spdk_scsi_task *scsi_task)
 	struct spdk_iscsi_task *task = spdk_iscsi_task_from_scsi_task(scsi_task);
 
 	spdk_iscsi_task_disassociate_pdu(task);
-	rte_mempool_put(g_spdk_iscsi.task_pool, (void *)task);
 	assert(task->conn->pending_task_cnt > 0);
 	task->conn->pending_task_cnt--;
+	rte_mempool_put(g_spdk_iscsi.task_pool, (void *)task);
 }
 
 struct spdk_iscsi_task *