ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/opal: Add check for strdup

Browse Source 
Change-Id: Ic3005bc0b854ed9e5ff4a2288c3715d1e79b1fb4
Signed-off-by: Chunyang Hui <chunyang.hui@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/472113
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Chunyang Hui 2019-10-23 22:36:07 +08:00 committed by Jim Harris
parent 173353baca
commit 71a1bbdd54
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
module/bdev/nvme/vbdev_opal.c
View File

@ -372,7 +372,11 @@ spdk_vbdev_opal_create(const char *nvme_ctrlr_name, uint32_t nsid, uint8_t locki
cfg = &opal_bdev->cfg;
cfg->nvme_ctrlr_name = strdup(nvme_ctrlr_name);
assert(cfg->nvme_ctrlr_name != NULL);
if (!cfg->nvme_ctrlr_name) {
SPDK_ERRLOG("allocation for nvme_ctrlr_name failed\n");
free(opal_bdev);
return -ENOMEM;
}
cfg->locking_range_id = locking_range_id;
cfg->range_start = range_start;
@ -427,7 +431,11 @@ spdk_vbdev_opal_create(const char *nvme_ctrlr_name, uint32_t nsid, uint8_t locki
}
opal_part_base->num_of_part = 0;
opal_part_base->nvme_ctrlr_name = strdup(cfg->nvme_ctrlr_name);
assert(opal_part_base->nvme_ctrlr_name != NULL);
if (opal_part_base->nvme_ctrlr_name == NULL) {
vbdev_opal_free_bdev(opal_bdev);
spdk_bdev_part_base_free(opal_part_base->part_base);
return -ENOMEM;
}
cfg->opal_base = opal_part_base;
TAILQ_INSERT_TAIL(&g_opal_base, opal_part_base, tailq);