From 6f6f08eda02455d702998957868b7961f4561a48 Mon Sep 17 00:00:00 2001 From: Ben Walker Date: Tue, 11 Jan 2022 13:13:42 -0700 Subject: [PATCH] idxd: Bump batch size to 32 Increase the batch size and with it the effective queue depth per channel to 512. Change-Id: Ide665e92d47ee753c141f34dd6a8bc4d040fe8db Signed-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11031 Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Reviewed-by: Jim Harris Reviewed-by: Changpeng Liu Reviewed-by: John Kariuki --- lib/idxd/idxd.h | 4 ++-- test/unit/lib/idxd/idxd_user.c/idxd_user_ut.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/idxd/idxd.h b/lib/idxd/idxd.h index 16c584ffd..17c27f5d0 100644 --- a/lib/idxd/idxd.h +++ b/lib/idxd/idxd.h @@ -61,8 +61,8 @@ static inline void movdir64b(void *dst, const void *src) /* TODO: consider setting the max per batch limit via RPC. */ -/* The following sets up a max desc count per batch of 16 */ -#define LOG2_WQ_MAX_BATCH 4 /* 2^4 = 16 */ +/* The following sets up a max desc count per batch of 32 */ +#define LOG2_WQ_MAX_BATCH 5 /* 2^5 = 32 */ #define DESC_PER_BATCH (1 << LOG2_WQ_MAX_BATCH) #define MIN_USER_DESC_COUNT 2 diff --git a/test/unit/lib/idxd/idxd_user.c/idxd_user_ut.c b/test/unit/lib/idxd/idxd_user.c/idxd_user_ut.c index 2f2eed4ff..0bfef74ed 100644 --- a/test/unit/lib/idxd/idxd_user.c/idxd_user_ut.c +++ b/test/unit/lib/idxd/idxd_user.c/idxd_user_ut.c @@ -107,7 +107,7 @@ test_idxd_wq_config(void) struct spdk_user_idxd_device user_idxd = {}; struct spdk_idxd_device *idxd = &user_idxd.idxd; union idxd_wqcfg wqcfg = {}; - uint32_t expected[8] = {0x40, 0, 0x11, 0x9e, 0, 0, 0x40000000, 0}; + uint32_t expected[8] = {0x40, 0, 0x11, 0xbe, 0, 0, 0x40000000, 0}; uint32_t wq_size; int rc, i, j;