From 6f442e50052925f7d04789bdc8eb2e3586911300 Mon Sep 17 00:00:00 2001 From: Maciej Wawryk Date: Mon, 30 Sep 2019 12:59:38 +0200 Subject: [PATCH] test: Shellcheck - correct rule "Remove surrounding $()" Correct shellcheck rule SC2091: Remove surrounding $() to avoid executing output. Signed-off-by: Maciej Wawryk Change-Id: Ie172da21e478b1f06132506459f0edf080455b75 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469860 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Reviewed-by: Karol Latecki Reviewed-by: Darek Stojaczyk --- scripts/check_format.sh | 2 +- test/ocf/management/create-destruct.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/check_format.sh b/scripts/check_format.sh index 849d7bcf3..20357e82b 100755 --- a/scripts/check_format.sh +++ b/scripts/check_format.sh @@ -243,7 +243,7 @@ if hash shellcheck 2>/dev/null; then SC1083,SC1090,SC1091,SC1113,SC2001,SC2002,SC2003,SC2004,SC2005,\ SC2010,SC2012,SC2013,SC2015,SC2016,SC2018,SC2019,SC2022,\ SC2027,SC2030,SC2031,SC2034,SC2035,SC2039,SC2043,SC2044,SC2045,SC2046,\ -SC2068,SC2086,SC2089,SC2090,SC2091,SC2094,\ +SC2068,SC2086,SC2089,SC2090,SC2094,\ SC2097,SC2098,SC2103,SC2115,SC2116,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\ SC2129,SC2140,SC2142,SC2143,SC2145,SC2146,SC2148,SC2152,SC2153,SC2154,SC2155,\ SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,SC2178,SC2181,\ diff --git a/test/ocf/management/create-destruct.sh b/test/ocf/management/create-destruct.sh index be6faeede..c31305df0 100755 --- a/test/ocf/management/create-destruct.sh +++ b/test/ocf/management/create-destruct.sh @@ -8,7 +8,7 @@ rpc_py=$rootdir/scripts/rpc.py function bdev_check_claimed() { - if $($rpc_py get_bdevs -b "$@" | jq '.[0].claimed'); then + if [ "$($rpc_py get_bdevs -b "$@" | jq '.[0].claimed')" = "true" ]; then return 0; else return 1;