From 6ed525207f0730c682bd167d673a57c4f279bc02 Mon Sep 17 00:00:00 2001 From: Maciej Wawryk Date: Wed, 23 Oct 2019 14:56:22 +0200 Subject: [PATCH] test: Shellcheck - include check SC2230 Remove from shellcheck excluded SC2230: which is non-standard. Use builtin 'command -v' instead. This warning is not actually present in any of spdk/spdk scripts. Signed-off-by: Maciej Wawryk Change-Id: I1e535b44ea54999736206aeb3906ce3cf670bc21 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/472171 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Paul Luse Reviewed-by: Shuhei Matsumoto --- scripts/check_format.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/check_format.sh b/scripts/check_format.sh index dc626c2b9..b29a44b94 100755 --- a/scripts/check_format.sh +++ b/scripts/check_format.sh @@ -244,8 +244,7 @@ if hash shellcheck 2>/dev/null; then SC2010,SC2012,SC2016,SC2034,SC2045,SC2046,SC2068,SC2086,SC2089,SC2090,\ SC2097,SC2098,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\ SC2129,SC2140,SC2142,SC2143,SC2148,SC2152,SC2153,SC2154,SC2155,\ -SC2162,SC2164,SC2165,SC2166,SC2167,\ -SC2230" +SC2162,SC2164,SC2165,SC2166,SC2167" # SPDK fails some error checks which have been deprecated in later versions of shellcheck. # We will not try to fix these error checks, but instead just leave the error types here # so that we can still run with older versions of shellcheck.