From 6da98786438a53b1442d001559dda1323f903b8f Mon Sep 17 00:00:00 2001 From: Alexey Marchuk Date: Tue, 17 Jan 2023 13:29:00 +0100 Subject: [PATCH] accel/dpdk_cryptodev: Fix io_dev unregister It was found that if system has no crypto devs, we exit earlier from init function and don't register io_device. Later in fini function we may try to unregister invalid io_device Signed-off-by: Alexey Marchuk Change-Id: I23ac9674c02d4fe97f01c66928a5ec5a2b39ec47 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16321 Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Paul Luse Reviewed-by: Jim Harris --- module/accel/dpdk_cryptodev/accel_dpdk_cryptodev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/module/accel/dpdk_cryptodev/accel_dpdk_cryptodev.c b/module/accel/dpdk_cryptodev/accel_dpdk_cryptodev.c index ed0c5894d..7fa123990 100644 --- a/module/accel/dpdk_cryptodev/accel_dpdk_cryptodev.c +++ b/module/accel/dpdk_cryptodev/accel_dpdk_cryptodev.c @@ -1314,7 +1314,9 @@ accel_dpdk_cryptodev_fini_cb(void *io_device) static void accel_dpdk_cryptodev_fini(void *ctx) { - spdk_io_device_unregister(&g_accel_dpdk_cryptodev_module, accel_dpdk_cryptodev_fini_cb); + if (g_crypto_op_mp) { + spdk_io_device_unregister(&g_accel_dpdk_cryptodev_module, accel_dpdk_cryptodev_fini_cb); + } } static void