ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/rpc: remove if checks for obligatory rpc arguments

Browse Source 
These arguments are obligatory and spdk_json_decode_object will
fail even before we reach the if block.

Change-Id: I3c17faf570aefc7d96d009a595cf3a76994977e7
Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462043
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Karol Latecki 2019-07-16 13:34:48 +02:00 committed by Darek Stojaczyk
parent 46ebf1b1e9
commit 6d442665fd
1 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/bdev/rpc/bdev_rpc.c
View File

@ -390,8 +390,6 @@ spdk_rpc_set_bdev_qd_sampling_period(struct spdk_jsonrpc_request *request,
struct spdk_bdev *bdev;
struct spdk_json_write_ctx *w;
req.period = UINT64_MAX;
if (spdk_json_decode_object(params, rpc_set_bdev_qd_sampling_period_decoders,
SPDK_COUNTOF(rpc_set_bdev_qd_sampling_period_decoders),
&req)) {
@ -399,21 +397,12 @@ spdk_rpc_set_bdev_qd_sampling_period(struct spdk_jsonrpc_request *request,
goto invalid;
}
if (req.name) {
bdev = spdk_bdev_get_by_name(req.name);
if (bdev == NULL) {
SPDK_ERRLOG("bdev '%s' does not exist\n", req.name);
goto invalid;
}
} else {
SPDK_ERRLOG("Missing name param\n");
bdev = spdk_bdev_get_by_name(req.name);
if (bdev == NULL) {
SPDK_ERRLOG("bdev '%s' does not exist\n", req.name);
goto invalid;
}
if (req.period == UINT64_MAX) {
SPDK_ERRLOG("Missing period param");
}
w = spdk_jsonrpc_begin_result(request);
spdk_bdev_set_qd_sampling_period(bdev, req.period);