ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmf: optimize listen address parsing code

Browse Source 
Optimize code

Signed-off-by: Anil Veerabhadrappa <anil.veerabhadrappa@broadcom.com>
Change-Id: I2debb9ec8af04a13feedfe53f56a3e539d06caf5
Signed-off-by: Anil Veerabhadrappa <anil.veerabhadrappa@broadcom.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/471206
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Alexey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Anil Veerabhadrappa 2019-10-13 21:08:23 -07:00 committed by Tomasz Zawadzki
parent 5e25bbdd49
commit 6d2989fdec
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
module/event/subsystems/nvmf/conf.c
View File

@ -290,6 +290,7 @@ spdk_nvmf_parse_subsystem(struct spdk_conf_section *sp)
{ {
const char *nqn, *mode; const char *nqn, *mode;
size_t i; size_t i;
int ret = -1;
int lcore; int lcore;
bool allow_any_host; bool allow_any_host;
bool allow_any_listener = true; bool allow_any_listener = true;
@ -459,19 +460,17 @@ spdk_nvmf_parse_subsystem(struct spdk_conf_section *sp)
if (trid.trtype == SPDK_NVME_TRANSPORT_RDMA || if (trid.trtype == SPDK_NVME_TRANSPORT_RDMA ||
trid.trtype == SPDK_NVME_TRANSPORT_TCP) { trid.trtype == SPDK_NVME_TRANSPORT_TCP) {
if (spdk_nvmf_tgt_parse_listen_ip_addr(address_dup, &trid)) { ret = spdk_nvmf_tgt_parse_listen_ip_addr(address_dup, &trid);
free(address_dup);
continue;
}
} else if (trid.trtype == SPDK_NVME_TRANSPORT_FC) { } else if (trid.trtype == SPDK_NVME_TRANSPORT_FC) {
if (spdk_nvmf_tgt_parse_listen_fc_addr(address_dup, &trid)) { ret = spdk_nvmf_tgt_parse_listen_fc_addr(address_dup, &trid);
free(address_dup);
continue;
}
} }
free(address_dup); free(address_dup);
if (ret) {
continue;
}
spdk_nvmf_tgt_listen(g_spdk_nvmf_tgt, &trid, spdk_nvmf_tgt_listen_done, NULL); spdk_nvmf_tgt_listen(g_spdk_nvmf_tgt, &trid, spdk_nvmf_tgt_listen_done, NULL);
spdk_nvmf_subsystem_add_listener(subsystem, &trid); spdk_nvmf_subsystem_add_listener(subsystem, &trid);