From 6d230de495b9193673dcbbd188419435d04e9708 Mon Sep 17 00:00:00 2001 From: Michal Berger Date: Wed, 19 Feb 2020 16:44:02 +0100 Subject: [PATCH] test/blobfs: Don't allow run_bsdump() to fail from within the trap call If this call fails, for whatever reason, $ROCKSDB_CONF won't be removed. Change-Id: I6fff996b04415fc760d3593c0f628d2631ce96ba Signed-off-by: Michal Berger Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/960 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Darek Stojaczyk --- test/blobfs/rocksdb/rocksdb.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/blobfs/rocksdb/rocksdb.sh b/test/blobfs/rocksdb/rocksdb.sh index 5fef7725c..61afdf8e9 100755 --- a/test/blobfs/rocksdb/rocksdb.sh +++ b/test/blobfs/rocksdb/rocksdb.sh @@ -67,7 +67,7 @@ $rootdir/scripts/gen_nvme.sh > $ROCKSDB_CONF echo "[Global]" >> $ROCKSDB_CONF echo "TpointGroupMask 0x80" >> $ROCKSDB_CONF -trap 'dump_db_bench_on_err; run_bsdump; rm -f $ROCKSDB_CONF; exit 1' SIGINT SIGTERM EXIT +trap 'dump_db_bench_on_err; run_bsdump || :; rm -f $ROCKSDB_CONF; exit 1' SIGINT SIGTERM EXIT if [ -z "$SKIP_MKFS" ]; then run_test "blobfs_mkfs" $rootdir/test/blobfs/mkfs/mkfs $ROCKSDB_CONF Nvme0n1