From 6cf97693e4f25467a6dac9023ba00b3e68280dd5 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Wed, 16 Dec 2020 22:21:59 +0000 Subject: [PATCH] Revert "nvmf/fc: Initialize transport id for the newly created FC transport qpair" This reverts commit 9ef1496ba59af45f23cb0225b77909accfc778f0. Reason for revert: The public API spdk_nvmf_qpair_get_listen_trid() was overlooked when this patch is created. Then the code to use the trid was replaced by spdk_nvmf_qpair_get_listen_trid(). To avoid someone from using the trid in future, revert this patch. struct spdk_nvmf_qpair is defined] in the public header file, nvmf_transport.h but it is mainly for pluggable custom transport. Any custom transport will not use the trid, and so even if we remove it, we will have no issue. Change-Id: I3bf500c27d9d47cc98ee84823b3c098ffcc56d90 Signed-off-by: Shuhei Matsumoto Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5615 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Anil Veerabhadrappa Reviewed-by: Aleksey Marchuk Reviewed-by: Changpeng Liu Reviewed-by: Jacek Kalwas --- lib/nvmf/fc_ls.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/nvmf/fc_ls.c b/lib/nvmf/fc_ls.c index 869d780c2..90feeb8b8 100644 --- a/lib/nvmf/fc_ls.c +++ b/lib/nvmf/fc_ls.c @@ -360,7 +360,6 @@ nvmf_fc_ls_new_connection(struct spdk_nvmf_fc_association *assoc, uint16_t qid, */ nvmf_fc_create_trid(&fc_conn->trid, tgtport->fc_nodename.u.wwn, tgtport->fc_portname.u.wwn); - fc_conn->qpair.trid = &fc_conn->trid; return fc_conn; }