From 6b97cccf34d5f22fd8a8cc019fb16a36aab7711e Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Fri, 13 Jan 2023 17:27:12 +0000 Subject: [PATCH] bdev, bdev_nvme: deprecate VTUNE support This VTune integration was added many years ago, but hasn't been tested and to my knowledge is not being used by anyone. The statistics it enables are very limited, specific to the bdev nvme module with no insight into the rest of an SPDK application. So deprecate this support now, we will remove it immediately after the v23.01 release. Signed-off-by: Jim Harris Change-Id: I5552d85084c350e9d0b2570946801acd65a89d64 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16294 Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Shuhei Matsumoto --- configure | 3 ++- lib/bdev/bdev.c | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index f093aeb72..abb08e5d1 100755 --- a/configure +++ b/configure @@ -91,7 +91,7 @@ function usage() { echo " --without-shared No path required." echo " --with-iscsi-initiator Build with iscsi bdev module." echo " --without-iscsi-initiator No path required." - echo " --with-vtune=DIR Required to profile I/O under Intel VTune Amplifier XE." + echo " --with-vtune=DIR Required to profile I/O under Intel VTune Amplifier XE. (Deprecated)" echo " --without-vtune example: /opt/intel/vtune_amplifier_xe_version" echo " --with-ocf[=DIR] Build OCF library and bdev module." echo " --without-ocf If argument is directory, interpret it as root of OCF repo" @@ -765,6 +765,7 @@ else fi if [ "${CONFIG[VTUNE]}" = "y" ]; then + echo "WARNING: VTune support is deprecated." if [ -z "${CONFIG[VTUNE_DIR]}" ]; then echo "When VTune is enabled, you must specify the VTune directory using --with-vtune=path" exit 1 diff --git a/lib/bdev/bdev.c b/lib/bdev/bdev.c index 9f02b3bb3..c9d47fa59 100644 --- a/lib/bdev/bdev.c +++ b/lib/bdev/bdev.c @@ -64,6 +64,8 @@ int __itt_init_ittlib(const char *, __itt_group_id); SPDK_LOG_DEPRECATION_REGISTER(bdev_register_examine_thread, "bdev register and examine on non-app thread", "SPDK 23.05", 0); +SPDK_LOG_DEPRECATION_REGISTER(vtune_support, "Intel(R) VTune integration", "SPDK 23.05", 0); + static const char *qos_rpc_type[] = {"rw_ios_per_sec", "rw_mbytes_per_sec", "r_mbytes_per_sec", "w_mbytes_per_sec" }; @@ -1682,6 +1684,7 @@ spdk_bdev_initialize(spdk_bdev_init_cb cb_fn, void *cb_arg) } #ifdef SPDK_CONFIG_VTUNE + SPDK_LOG_DEPRECATED(vtune_support); g_bdev_mgr.domain = __itt_domain_create("spdk_bdev"); #endif