ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Always append one double quote char in the end of string

Browse Source 
The returned value write_string_or_name() is not really checked, so one double quote char error
is not identified and the broken json string is directly sent to the client.

To address the issue, the workaround is always appending one double quote char in the end of string.

TODO:
1. Find the root cause
2. Check the returned value of write_string_or_name()

Longhorn 6190

Signed-off-by: Derek Su <derek.su@suse.com>
This commit is contained in:
Derek Su 2023-06-27 08:03:33 +08:00 committed by David Ko
parent c1d0ea9a39
commit 69f656824e
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/json/json_write.c
View File

@ -393,6 +393,9 @@ write_string_or_name(struct spdk_json_write_ctx *w, const char *val, size_t len)
{
const uint8_t *p = val;
const uint8_t *end = val + len;
bool failed = false;
int retval;
if (emit(w, "\"", 1)) { return fail(w); }
@ -415,14 +418,25 @@ write_string_or_name(struct spdk_json_write_ctx *w, const char *val, size_t len)
codepoint = utf8_decode_unsafe_4(p);
break;
default:
return fail(w);
failed = true;
break;
}
if (failed) {
break;
}
if (write_codepoint(w, codepoint)) { return fail(w); }
p += codepoint_len;
}
return emit(w, "\"", 1);
// Always append "\"" in the end of string
retval = emit(w, "\"", 1);
if (failed) {
return fail(w);
}
return retval;
}
static int