From 669069da0f7289defa60f05717228f84b273d345 Mon Sep 17 00:00:00 2001 From: Nathan Claudel Date: Fri, 4 Nov 2022 15:40:03 +0100 Subject: [PATCH] lvol: fix jsonrpc error code sign in create_lvstore `vbdev_lvs_create` returns negative errnos. The sign was flipped here. Change-Id: I57e0813c2ecd10695395273a1c4ea750ef00b930 Signed-off-by: Nathan Claudel Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15273 Tested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber Reviewed-by: Tomasz Zawadzki --- module/bdev/lvol/vbdev_lvol_rpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/bdev/lvol/vbdev_lvol_rpc.c b/module/bdev/lvol/vbdev_lvol_rpc.c index 49a0cc586..5d1a99cf6 100644 --- a/module/bdev/lvol/vbdev_lvol_rpc.c +++ b/module/bdev/lvol/vbdev_lvol_rpc.c @@ -124,7 +124,7 @@ rpc_bdev_lvol_create_lvstore(struct spdk_jsonrpc_request *request, rc = vbdev_lvs_create(req.bdev_name, req.lvs_name, req.cluster_sz, clear_method, req.num_md_pages_per_cluster_ratio, rpc_lvol_store_construct_cb, request); if (rc < 0) { - spdk_jsonrpc_send_error_response(request, -rc, spdk_strerror(rc)); + spdk_jsonrpc_send_error_response(request, rc, spdk_strerror(-rc)); goto cleanup; } free_rpc_bdev_lvol_create_lvstore(&req);