ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmf/fc: optimize code to access structure members only when needed

Browse Source 
Reference the struct members only when it is necessary.

Signed-off-by: Anil Veerabhadrappa <anil.veerabhadrappa@broadcom.com>
Change-Id: I44208dfde20f74ab96e494445a464bf45f7ab408
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5070
Community-CI: Broadcom CI
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Anil Veerabhadrappa 2020-11-10 10:26:21 -08:00 committed by Jim Harris
parent 33e1f4b0e2
commit 65b5866e0e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/nvmf/fc.c
View File

@ -1431,9 +1431,7 @@ void
_nvmf_fc_request_free(struct spdk_nvmf_fc_request *fc_req)
{
struct spdk_nvmf_fc_hwqp *hwqp = fc_req->hwqp;
struct spdk_nvmf_fc_poll_group *fgroup = hwqp->fgroup;
struct spdk_nvmf_transport_poll_group *group = &fgroup->group;
struct spdk_nvmf_transport *transport = group->transport;
struct spdk_nvmf_transport_poll_group *group;
if (!fc_req) {
return;
@ -1446,7 +1444,9 @@ _nvmf_fc_request_free(struct spdk_nvmf_fc_request *fc_req)
/* Release IO buffers */
if (fc_req->req.data_from_pool) {
spdk_nvmf_request_free_buffers(&fc_req->req, group, transport);
group = &hwqp->fgroup->group;
spdk_nvmf_request_free_buffers(&fc_req->req, group,
group->transport);
}
fc_req->req.data = NULL;
fc_req->req.iovcnt = 0;