ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme: add KEYED_DATA_BLOCK to sgl_types

Browse Source 
This SGL type was missed in the original commit
that added the pretty printing.

Fixes: 4d9ab1e9a1 ("nvme: pretty print dptr")

Reported-by: Ramanjaneya Burugula <burugula@gmail.com>
Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Ibc655db4e65009071f39f55f691c94a094cea0bc
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12705
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
This commit is contained in:
Jim Harris 2022-04-20 00:59:03 +00:00 committed by Tomasz Zawadzki
parent 9b5dabff7f
commit 64df311eba
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/nvme/nvme_qpair.c
View File

@ -136,6 +136,7 @@ static const struct nvme_string sgl_type[] = {
{ SPDK_NVME_SGL_TYPE_BIT_BUCKET, "BIT BUCKET" }, { SPDK_NVME_SGL_TYPE_BIT_BUCKET, "BIT BUCKET" },
{ SPDK_NVME_SGL_TYPE_SEGMENT, "SEGMENT" }, { SPDK_NVME_SGL_TYPE_SEGMENT, "SEGMENT" },
{ SPDK_NVME_SGL_TYPE_LAST_SEGMENT, "LAST SEGMENT" }, { SPDK_NVME_SGL_TYPE_LAST_SEGMENT, "LAST SEGMENT" },
{ SPDK_NVME_SGL_TYPE_KEYED_DATA_BLOCK, "KEYED DATA BLOCK" },
{ SPDK_NVME_SGL_TYPE_TRANSPORT_DATA_BLOCK, "TRANSPORT DATA BLOCK" }, { SPDK_NVME_SGL_TYPE_TRANSPORT_DATA_BLOCK, "TRANSPORT DATA BLOCK" },
{ SPDK_NVME_SGL_TYPE_VENDOR_SPECIFIC, "VENDOR SPECIFIC" }, { SPDK_NVME_SGL_TYPE_VENDOR_SPECIFIC, "VENDOR SPECIFIC" },
{ 0xFFFF, "RESERVED" } { 0xFFFF, "RESERVED" }

2
test/unit/lib/nvme/nvme_qpair.c/nvme_qpair_ut.c
View File

@ -756,7 +756,7 @@ test_nvme_get_sgl_print_info(void)
cmd.dptr.sgl1.keyed.key = 0xababccdd; cmd.dptr.sgl1.keyed.key = 0xababccdd;
nvme_get_sgl(buf, NVME_CMD_DPTR_STR_SIZE, &cmd); nvme_get_sgl(buf, NVME_CMD_DPTR_STR_SIZE, &cmd);
CU_ASSERT(!strncmp(buf, "SGL RESERVED ADDRESS 0xdeadbeef len:0x1000 key:0xababccdd", CU_ASSERT(!strncmp(buf, "SGL KEYED DATA BLOCK ADDRESS 0xdeadbeef len:0x1000 key:0xababccdd",
NVME_CMD_DPTR_STR_SIZE)); NVME_CMD_DPTR_STR_SIZE));
} }