ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/reduce: rename init() unit test to init_failure()

Browse Source 
There are now other unit tests which exercise the success path.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I601395aff7d3c5e88bdcf2986a25e71b0e2f5d39

Reviewed-on: https://review.gerrithub.io/432500
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Jim Harris 2018-10-01 12:18:30 -07:00
parent 5aace13984
commit 649a585f2f
1 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/unit/lib/reduce/reduce.c/reduce_ut.c
View File

@ -195,7 +195,7 @@ unload_cb(void *cb_arg, int ziperrno)
} }
static void static void
init(void) init_failure(void)
{ {
struct spdk_reduce_vol_params params = {}; struct spdk_reduce_vol_params params = {};
struct spdk_reduce_backing_dev backing_dev = {}; struct spdk_reduce_backing_dev backing_dev = {};
@ -236,21 +236,7 @@ init(void)
CU_ASSERT(g_ziperrno == -EINVAL); CU_ASSERT(g_ziperrno == -EINVAL);
SPDK_CU_ASSERT_FATAL(g_vol == NULL); SPDK_CU_ASSERT_FATAL(g_vol == NULL);
/* Now specify a uuid. spdk_reduce_vol_init() should then pass. */ pm_file_close(&pm_file);
spdk_uuid_generate(&params.uuid);
g_vol = NULL;
g_ziperrno = -1;
spdk_reduce_vol_init(&params, &backing_dev, &pm_file, init_cb, NULL);
CU_ASSERT(g_ziperrno == 0);
SPDK_CU_ASSERT_FATAL(g_vol != NULL);
CU_ASSERT(spdk_uuid_compare(&params.uuid, &g_vol->uuid) == 0);
g_ziperrno = -1;
spdk_reduce_vol_unload(g_vol, unload_cb, NULL);
CU_ASSERT(g_ziperrno == 0);
CU_ASSERT(g_volatile_pm_buf == NULL);
pm_file_destroy(); pm_file_destroy();
} }
@ -309,7 +295,7 @@ main(int argc, char **argv)
if ( if (
CU_add_test(suite, "get_pm_file_size", get_pm_file_size) == NULL || CU_add_test(suite, "get_pm_file_size", get_pm_file_size) == NULL ||
CU_add_test(suite, "get_backing_device_size", get_backing_device_size) == NULL || CU_add_test(suite, "get_backing_device_size", get_backing_device_size) == NULL ||
CU_add_test(suite, "init", init) == NULL || CU_add_test(suite, "init_failure", init_failure) == NULL ||
CU_add_test(suite, "init_md", init_md) == NULL CU_add_test(suite, "init_md", init_md) == NULL
) { ) {
CU_cleanup_registry(); CU_cleanup_registry();