ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/reduce: eliminate RMW on writes with chunk_size length

Browse Source 
Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: I6545a91e2ae4805f7bd1d92baa6dcbce0f1f8fba
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459864
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
paul luse 2019-06-29 17:17:24 -04:00 committed by Darek Stojaczyk
parent d23c36a169
commit 63d9d2e2b0
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/reduce/reduce.c
View File

@ -1363,12 +1363,13 @@ _start_writev_request(struct spdk_reduce_vol_request *req)
TAILQ_INSERT_TAIL(&req->vol->executing_requests, req, tailq); TAILQ_INSERT_TAIL(&req->vol->executing_requests, req, tailq);
if (vol->pm_logical_map[req->logical_map_index] != REDUCE_EMPTY_MAP_ENTRY) { if (vol->pm_logical_map[req->logical_map_index] != REDUCE_EMPTY_MAP_ENTRY) {
/* Read old chunk, then overwrite with data from this write operation. if ((req->length * vol->params.logical_block_size) < vol->params.chunk_size) {
* TODO: bypass reading old chunk if this write operation overwrites /* Read old chunk, then overwrite with data from this write
* the entire chunk. * operation.
*/ */
_reduce_vol_read_chunk(req, _write_read_done); _reduce_vol_read_chunk(req, _write_read_done);
return; return;
}
} }
lbsize = vol->params.logical_block_size; lbsize = vol->params.logical_block_size;