ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/nvme_arbitration: use extended block size API

Browse Source 
spdk_nvme_ns_get_extended_sector_size() is same with
spdk_nvme_ns_get_sector_size() if the drive wasn't
formatted to extended LBA format, but if the drive
was using extended LBA format, it will cause error
without this patch.

Change-Id: Ie845453949c65a9f1d1370227fe3363648f0d0d9
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2934
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
This commit is contained in:
Changpeng Liu 2020-06-18 00:56:19 -04:00 committed by Tomasz Zawadzki
parent bd7689bd18
commit 6366e361fe
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
examples/nvme/arbitration/arbitration.c
View File

@ -159,11 +159,12 @@ register_ns(struct spdk_nvme_ctrlr *ctrlr, struct spdk_nvme_ns *ns)
cdata = spdk_nvme_ctrlr_get_data(ctrlr); cdata = spdk_nvme_ctrlr_get_data(ctrlr);
if (spdk_nvme_ns_get_size(ns) < g_arbitration.io_size_bytes || if (spdk_nvme_ns_get_size(ns) < g_arbitration.io_size_bytes ||
spdk_nvme_ns_get_sector_size(ns) > g_arbitration.io_size_bytes) { spdk_nvme_ns_get_extended_sector_size(ns) > g_arbitration.io_size_bytes ||
g_arbitration.io_size_bytes % spdk_nvme_ns_get_extended_sector_size(ns)) {
printf("WARNING: controller %-20.20s (%-20.20s) ns %u has invalid " printf("WARNING: controller %-20.20s (%-20.20s) ns %u has invalid "
"ns size %" PRIu64 " / block size %u for I/O size %u\n", "ns size %" PRIu64 " / block size %u for I/O size %u\n",
cdata->mn, cdata->sn, spdk_nvme_ns_get_id(ns), cdata->mn, cdata->sn, spdk_nvme_ns_get_id(ns),
spdk_nvme_ns_get_size(ns), spdk_nvme_ns_get_sector_size(ns), spdk_nvme_ns_get_size(ns), spdk_nvme_ns_get_extended_sector_size(ns),
g_arbitration.io_size_bytes); g_arbitration.io_size_bytes);
return; return;
} }