diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index c3311d9be..c97c73226 100644 --- a/lib/vhost/vhost.c +++ b/lib/vhost/vhost.c @@ -48,15 +48,12 @@ static uint32_t *g_num_ctrlrs; /* Path to folder where character device will be created. Can be set by user. */ static char dev_dirname[PATH_MAX] = ""; -struct spdk_vhost_dev_event_ctx { - /** Pointer to the controller obtained before enqueuing the event */ +struct spdk_vhost_session_fn_ctx { + /** Device pointer obtained before enqueuing the event */ struct spdk_vhost_dev *vdev; - /** ID of the vdev to send event to. */ - unsigned vdev_id; - /** User callback function to be executed on given lcore. */ - spdk_vhost_event_fn cb_fn; + spdk_vhost_session_fn cb_fn; /** Semaphore used to signal that event is done. */ sem_t sem; @@ -508,20 +505,6 @@ spdk_vhost_vring_desc_to_iov(struct spdk_vhost_session *vsession, struct iovec * return 0; } -static struct spdk_vhost_dev * -spdk_vhost_dev_find_by_id(unsigned id) -{ - struct spdk_vhost_dev *vdev; - - TAILQ_FOREACH(vdev, &g_spdk_vhost_devices, tailq) { - if (vdev->id == id) { - return vdev; - } - } - - return NULL; -} - static struct spdk_vhost_session * spdk_vhost_session_find_by_vid(int vid) { @@ -658,24 +641,12 @@ int spdk_vhost_dev_register(struct spdk_vhost_dev *vdev, const char *name, const char *mask_str, const struct spdk_vhost_dev_backend *backend) { - static unsigned ctrlr_num; char path[PATH_MAX]; struct stat file_stat; struct spdk_cpuset *cpumask; int rc; assert(vdev); - - /* We expect devices inside g_spdk_vhost_devices to be sorted in ascending - * order in regard of vdev->id. For now we always set vdev->id = ctrlr_num++ - * and append each vdev to the very end of g_spdk_vhost_devices list. - * This is required for foreach vhost events to work. - */ - if (ctrlr_num == UINT_MAX) { - assert(false); - return -EINVAL; - } - if (name == NULL) { SPDK_ERRLOG("Can't register controller with no name\n"); return -EINVAL; @@ -761,8 +732,6 @@ spdk_vhost_dev_register(struct spdk_vhost_dev *vdev, const char *name, const cha vdev->name = strdup(name); vdev->path = strdup(path); - vdev->id = ctrlr_num++; - vdev->lcore = -1; vdev->cpumask = cpumask; vdev->registered = true; vdev->backend = backend; @@ -804,17 +773,10 @@ spdk_vhost_dev_unregister(struct spdk_vhost_dev *vdev) return 0; } -static struct spdk_vhost_dev * -spdk_vhost_dev_next(unsigned i) +static struct spdk_vhost_session * +spdk_vhost_session_next(struct spdk_vhost_dev *vdev, unsigned prev_id) { - struct spdk_vhost_dev *vdev; - - TAILQ_FOREACH(vdev, &g_spdk_vhost_devices, tailq) { - if (vdev->id > i) { - return vdev; - } - } - + /* so far there's only one session per device */ return NULL; } @@ -859,7 +821,7 @@ spdk_vhost_allocate_reactor(struct spdk_cpuset *cpumask) void spdk_vhost_dev_backend_event_done(void *event_ctx, int response) { - struct spdk_vhost_dev_event_ctx *ctx = event_ctx; + struct spdk_vhost_session_fn_ctx *ctx = event_ctx; ctx->response = response; sem_post(&ctx->sem); @@ -868,57 +830,21 @@ spdk_vhost_dev_backend_event_done(void *event_ctx, int response) static void spdk_vhost_event_cb(void *arg1, void *arg2) { - struct spdk_vhost_dev_event_ctx *ctx = arg1; + struct spdk_vhost_session_fn_ctx *ctx = arg1; - ctx->cb_fn(ctx->vdev, ctx); -} - -static void -spdk_vhost_event_async_fn(void *arg1, void *arg2) -{ - struct spdk_vhost_dev_event_ctx *ctx = arg1; - struct spdk_vhost_dev *vdev; - struct spdk_event *ev; - - if (pthread_mutex_trylock(&g_spdk_vhost_mutex) != 0) { - ev = spdk_event_allocate(spdk_env_get_current_core(), spdk_vhost_event_async_fn, arg1, arg2); - spdk_event_call(ev); - return; - } - - vdev = spdk_vhost_dev_find_by_id(ctx->vdev_id); - if (vdev != ctx->vdev) { - /* vdev has been changed after enqueuing this event */ - vdev = NULL; - } - - if (vdev != NULL && vdev->lcore >= 0 && - (uint32_t)vdev->lcore != spdk_env_get_current_core()) { - /* if vdev has been relocated to other core, it is no longer thread-safe - * to access its contents here. Even though we're running under global vhost - * mutex, the controller itself (and its pollers) are not. We need to chase - * the vdev thread as many times as necessary. - */ - ev = spdk_event_allocate(vdev->lcore, spdk_vhost_event_async_fn, arg1, arg2); - spdk_event_call(ev); - pthread_mutex_unlock(&g_spdk_vhost_mutex); - return; - } - - ctx->cb_fn(vdev, arg2); - pthread_mutex_unlock(&g_spdk_vhost_mutex); - - free(ctx); + ctx->cb_fn(ctx->vdev, ctx->vdev->session, ctx); } static void spdk_vhost_external_event_foreach_continue(struct spdk_vhost_dev *vdev, - spdk_vhost_event_fn fn, void *arg); + struct spdk_vhost_session *vsession, + spdk_vhost_session_fn fn, void *arg); static void spdk_vhost_event_async_foreach_fn(void *arg1, void *arg2) { - struct spdk_vhost_dev_event_ctx *ctx = arg1; - struct spdk_vhost_dev *vdev; + struct spdk_vhost_session_fn_ctx *ctx = arg1; + struct spdk_vhost_session *vsession = NULL; + struct spdk_vhost_dev *vdev = ctx->vdev; struct spdk_event *ev; int rc; @@ -929,48 +855,39 @@ spdk_vhost_event_async_foreach_fn(void *arg1, void *arg2) return; } - vdev = spdk_vhost_dev_find_by_id(ctx->vdev_id); - if (vdev != ctx->vdev) { - /* ctx->vdev is probably a dangling pointer at this point. - * It must have been removed in the meantime, so we just skip - * it in our foreach chain. */ - goto out_unlock_continue; - } - - /* the assert is just for static analyzers, vdev cannot be NULL here */ - assert(vdev != NULL); - if (vdev->lcore >= 0 && - (uint32_t)vdev->lcore != spdk_env_get_current_core()) { - /* if vdev has been relocated to other core, it is no longer thread-safe - * to access its contents here. Even though we're running under global vhost - * mutex, the controller itself (and its pollers) are not. We need to chase - * the vdev thread as many times as necessary. + vsession = vdev->session; + if (vsession != NULL && vsession->lcore >= 0 && + (uint32_t)vsession->lcore != spdk_env_get_current_core()) { + /* if session has been relocated to other core, it is no longer thread-safe + * to access its contents here. Even though we're running under the global + * vhost mutex, the session itself (and its pollers) are not. We need to chase + * the session thread as many times as necessary. */ - ev = spdk_event_allocate(vdev->lcore, + ev = spdk_event_allocate(vsession->lcore, spdk_vhost_event_async_foreach_fn, arg1, arg2); spdk_event_call(ev); pthread_mutex_unlock(&g_spdk_vhost_mutex); return; } - rc = ctx->cb_fn(vdev, arg2); + rc = ctx->cb_fn(vdev, vsession, arg2); if (rc < 0) { - goto out_unlock_return; + goto out_unlock; } -out_unlock_continue: - vdev = spdk_vhost_dev_next(ctx->vdev_id); - spdk_vhost_external_event_foreach_continue(vdev, ctx->cb_fn, arg2); -out_unlock_return: + /* FIXME use a real session ID */ + vsession = spdk_vhost_session_next(vdev, -1); + spdk_vhost_external_event_foreach_continue(vdev, vsession, ctx->cb_fn, arg2); +out_unlock: pthread_mutex_unlock(&g_spdk_vhost_mutex); free(ctx); } static int -_spdk_vhost_event_send(struct spdk_vhost_dev *vdev, spdk_vhost_event_fn cb_fn, +_spdk_vhost_event_send(struct spdk_vhost_session *vsession, spdk_vhost_session_fn cb_fn, unsigned timeout_sec, const char *errmsg) { - struct spdk_vhost_dev_event_ctx ev_ctx = {0}; + struct spdk_vhost_session_fn_ctx ev_ctx = {0}; struct spdk_event *ev; struct timespec timeout; int rc; @@ -981,9 +898,9 @@ _spdk_vhost_event_send(struct spdk_vhost_dev *vdev, spdk_vhost_event_fn cb_fn, return -errno; } - ev_ctx.vdev = vdev; + ev_ctx.vdev = vsession->vdev; ev_ctx.cb_fn = cb_fn; - ev = spdk_event_allocate(vdev->lcore, spdk_vhost_event_cb, &ev_ctx, NULL); + ev = spdk_event_allocate(vsession->lcore, spdk_vhost_event_cb, &ev_ctx, NULL); assert(ev); spdk_event_call(ev); pthread_mutex_unlock(&g_spdk_vhost_mutex); @@ -1003,12 +920,12 @@ _spdk_vhost_event_send(struct spdk_vhost_dev *vdev, spdk_vhost_event_fn cb_fn, } static int -spdk_vhost_event_async_send(struct spdk_vhost_dev *vdev, spdk_vhost_event_fn cb_fn, void *arg, - bool foreach) +spdk_vhost_event_async_send_foreach_continue(struct spdk_vhost_session *vsession, + spdk_vhost_session_fn cb_fn, void *arg) { - struct spdk_vhost_dev_event_ctx *ev_ctx; + struct spdk_vhost_dev *vdev = vsession->vdev; + struct spdk_vhost_session_fn_ctx *ev_ctx; struct spdk_event *ev; - spdk_event_fn fn; ev_ctx = calloc(1, sizeof(*ev_ctx)); if (ev_ctx == NULL) { @@ -1018,11 +935,10 @@ spdk_vhost_event_async_send(struct spdk_vhost_dev *vdev, spdk_vhost_event_fn cb_ } ev_ctx->vdev = vdev; - ev_ctx->vdev_id = vdev->id; ev_ctx->cb_fn = cb_fn; - fn = foreach ? spdk_vhost_event_async_foreach_fn : spdk_vhost_event_async_fn; - ev = spdk_event_allocate(ev_ctx->vdev->lcore, fn, ev_ctx, arg); + ev = spdk_event_allocate(vsession->lcore, + spdk_vhost_event_async_foreach_fn, ev_ctx, arg); assert(ev); spdk_event_call(ev); @@ -1047,13 +963,13 @@ stop_device(int vid) } vdev = vsession->vdev; - if (vdev->lcore == -1) { + if (vsession->lcore == -1) { SPDK_ERRLOG("Controller %s is not loaded.\n", vdev->name); pthread_mutex_unlock(&g_spdk_vhost_mutex); return; } - rc = _spdk_vhost_event_send(vdev, vdev->backend->stop_device, 3, "stop device"); + rc = _spdk_vhost_event_send(vsession, vdev->backend->stop_session, 3, "stop session"); if (rc != 0) { SPDK_ERRLOG("Couldn't stop device with vid %d.\n", vid); pthread_mutex_unlock(&g_spdk_vhost_mutex); @@ -1070,8 +986,8 @@ stop_device(int vid) spdk_vhost_session_mem_unregister(vsession); free(vsession->mem); - spdk_vhost_free_reactor(vdev->lcore); - vdev->lcore = -1; + spdk_vhost_free_reactor(vsession->lcore); + vsession->lcore = -1; assert(vdev->active_session_num > 0); vdev->active_session_num--; pthread_mutex_unlock(&g_spdk_vhost_mutex); @@ -1094,7 +1010,7 @@ start_device(int vid) } vdev = vsession->vdev; - if (vdev->lcore != -1) { + if (vsession->lcore != -1) { SPDK_ERRLOG("Controller %s already loaded.\n", vdev->name); goto out; } @@ -1146,14 +1062,14 @@ start_device(int vid) } spdk_vhost_session_set_coalescing(vdev, vsession, NULL); - vdev->lcore = spdk_vhost_allocate_reactor(vdev->cpumask); + vsession->lcore = spdk_vhost_allocate_reactor(vdev->cpumask); spdk_vhost_session_mem_register(vsession); - rc = _spdk_vhost_event_send(vdev, vdev->backend->start_device, 3, "start device"); + rc = _spdk_vhost_event_send(vsession, vdev->backend->start_session, 3, "start session"); if (rc != 0) { spdk_vhost_session_mem_unregister(vsession); free(vsession->mem); - spdk_vhost_free_reactor(vdev->lcore); - vdev->lcore = -1; + spdk_vhost_free_reactor(vsession->lcore); + vsession->lcore = -1; goto out; } @@ -1261,6 +1177,10 @@ spdk_vhost_dump_info_json(struct spdk_vhost_dev *vdev, struct spdk_json_write_ct int spdk_vhost_dev_remove(struct spdk_vhost_dev *vdev) { + if (vdev->pending_async_op_num) { + return -EBUSY; + } + return vdev->backend->remove_device(vdev); } @@ -1302,6 +1222,7 @@ new_connection(int vid) vsession->vdev = vdev; vsession->vid = vid; + vsession->lcore = -1; vsession->next_stats_check_time = 0; vsession->stats_check_interval = SPDK_VHOST_STATS_CHECK_INTERVAL_MS * spdk_get_ticks_hz() / 1000UL; @@ -1335,72 +1256,64 @@ spdk_vhost_call_external_event(const char *ctrlr_name, spdk_vhost_event_fn fn, v pthread_mutex_lock(&g_spdk_vhost_mutex); vdev = spdk_vhost_dev_find(ctrlr_name); - - if (vdev == NULL) { - pthread_mutex_unlock(&g_spdk_vhost_mutex); - fn(NULL, arg); - return; - } - - if (vdev->lcore == -1) { - fn(vdev, arg); - } else { - spdk_vhost_event_async_send(vdev, fn, arg, false); - } - + fn(vdev, arg); pthread_mutex_unlock(&g_spdk_vhost_mutex); } static void spdk_vhost_external_event_foreach_continue(struct spdk_vhost_dev *vdev, - spdk_vhost_event_fn fn, void *arg) + struct spdk_vhost_session *vsession, + spdk_vhost_session_fn fn, void *arg) { int rc; - if (vdev == NULL) { - fn(NULL, arg); - return; + if (vsession == NULL) { + goto out_finish_foreach; } - while (vdev->lcore == -1) { - rc = fn(vdev, arg); + while (vsession->lcore == -1) { + rc = fn(vdev, vsession, arg); if (rc < 0) { return; } - - vdev = spdk_vhost_dev_next(vdev->id); - if (vdev == NULL) { - fn(NULL, arg); - return; + /* FIXME use a real session ID */ + vsession = spdk_vhost_session_next(vdev, -1); + if (vsession == NULL) { + goto out_finish_foreach; } } - spdk_vhost_event_async_send(vdev, fn, arg, true); + spdk_vhost_event_async_send_foreach_continue(vsession, fn, arg); + return; + +out_finish_foreach: + /* there are no more sessions to iterate through, so call the + * fn one last time with vsession == NULL + */ + assert(vdev->pending_async_op_num > 0); + vdev->pending_async_op_num--; + fn(vdev, NULL, arg); } void spdk_vhost_dev_foreach_session(struct spdk_vhost_dev *vdev, spdk_vhost_session_fn fn, void *arg) { - int rc = 0; - - if (vdev->session != NULL) { - rc = fn(vdev, vdev->session, arg); - } - - if (rc >= 0) { - fn(vdev, NULL, arg); - } + assert(vdev->pending_async_op_num < UINT32_MAX); + vdev->pending_async_op_num++; + spdk_vhost_external_event_foreach_continue(vdev, vdev->session, fn, arg); } void spdk_vhost_call_external_event_foreach(spdk_vhost_event_fn fn, void *arg) { - struct spdk_vhost_dev *vdev; + struct spdk_vhost_dev *vdev, *tmp; pthread_mutex_lock(&g_spdk_vhost_mutex); - vdev = TAILQ_FIRST(&g_spdk_vhost_devices); - spdk_vhost_external_event_foreach_continue(vdev, fn, arg); + TAILQ_FOREACH_SAFE(vdev, &g_spdk_vhost_devices, tailq, tmp) { + fn(vdev, arg); + } + fn(NULL, arg); pthread_mutex_unlock(&g_spdk_vhost_mutex); } @@ -1472,6 +1385,7 @@ _spdk_vhost_fini_remove_vdev_cb(struct spdk_vhost_dev *vdev, void *arg) if (vdev != NULL) { spdk_vhost_dev_remove(vdev); + /* don't care if it fails, there's nothing we can do for now */ return 0; } diff --git a/lib/vhost/vhost_blk.c b/lib/vhost/vhost_blk.c index 9c580d2ef..80f765861 100644 --- a/lib/vhost/vhost_blk.c +++ b/lib/vhost/vhost_blk.c @@ -664,16 +664,11 @@ alloc_task_pool(struct spdk_vhost_blk_session *bvsession) return 0; } -/* - * A new device is added to a data core. First the device is added to the main linked list - * and then allocated to a specific data core. - * - */ static int -spdk_vhost_blk_start(struct spdk_vhost_dev *vdev, void *event_ctx) +spdk_vhost_blk_start(struct spdk_vhost_dev *vdev, + struct spdk_vhost_session *vsession, void *event_ctx) { struct spdk_vhost_blk_dev *bvdev; - struct spdk_vhost_session *vsession = vdev->session; struct spdk_vhost_blk_session *bvsession; int i, rc = 0; @@ -715,7 +710,7 @@ spdk_vhost_blk_start(struct spdk_vhost_dev *vdev, void *event_ctx) bvsession->requestq_poller = spdk_poller_register(bvdev->bdev ? vdev_worker : no_bdev_vdev_worker, bvsession, 0); SPDK_INFOLOG(SPDK_LOG_VHOST, "Started poller for vhost controller %s on lcore %d\n", - vdev->name, vdev->lcore); + vdev->name, vsession->lcore); out: spdk_vhost_dev_backend_event_done(event_ctx, rc); return rc; @@ -752,9 +747,9 @@ destroy_session_poller_cb(void *arg) } static int -spdk_vhost_blk_stop(struct spdk_vhost_dev *vdev, void *event_ctx) +spdk_vhost_blk_stop(struct spdk_vhost_dev *vdev, + struct spdk_vhost_session *vsession, void *event_ctx) { - struct spdk_vhost_session *vsession = vdev->session; struct spdk_vhost_blk_session *bvsession; bvsession = to_blk_session(vsession); @@ -909,8 +904,8 @@ static const struct spdk_vhost_dev_backend vhost_blk_device_backend = { (1ULL << VIRTIO_BLK_F_BARRIER) | (1ULL << VIRTIO_BLK_F_SCSI) | (1ULL << VIRTIO_BLK_F_DISCARD) | (1ULL << VIRTIO_BLK_F_WRITE_ZEROES), .session_ctx_size = sizeof(struct spdk_vhost_blk_session) - sizeof(struct spdk_vhost_session), - .start_device = spdk_vhost_blk_start, - .stop_device = spdk_vhost_blk_stop, + .start_session = spdk_vhost_blk_start, + .stop_session = spdk_vhost_blk_stop, .vhost_get_config = spdk_vhost_blk_get_config, .dump_info_json = spdk_vhost_blk_dump_info_json, .write_config_json = spdk_vhost_blk_write_config_json, diff --git a/lib/vhost/vhost_internal.h b/lib/vhost/vhost_internal.h index 960600b88..ea00e8b23 100644 --- a/lib/vhost/vhost_internal.h +++ b/lib/vhost/vhost_internal.h @@ -117,6 +117,8 @@ struct spdk_vhost_session { /* rte_vhost connection ID. */ int vid; + int32_t lcore; + struct rte_vhost_memory *mem; int task_cnt; @@ -142,10 +144,6 @@ struct spdk_vhost_dev { char *name; char *path; - /* Unique device ID. */ - unsigned id; - - int32_t lcore; struct spdk_cpuset *cpumask; bool registered; @@ -163,6 +161,9 @@ struct spdk_vhost_dev { /* Number of started and actively polled sessions */ uint32_t active_session_num; + /* Number of pending asynchronous operations */ + uint32_t pending_async_op_num; + TAILQ_ENTRY(spdk_vhost_dev) tailq; }; @@ -201,13 +202,12 @@ struct spdk_vhost_dev_backend { size_t session_ctx_size; /** - * Callbacks for starting and pausing the device. - * The first param is struct spdk_vhost_dev *. - * The second one is event context that has to be + * Callbacks for starting and pausing a session. + * The third param is an event context that has to be * passed to spdk_vhost_dev_backend_event_done(). */ - spdk_vhost_event_fn start_device; - spdk_vhost_event_fn stop_device; + spdk_vhost_session_fn start_session; + spdk_vhost_session_fn stop_session; int (*vhost_get_config)(struct spdk_vhost_dev *vdev, uint8_t *config, uint32_t len); int (*vhost_set_config)(struct spdk_vhost_dev *vdev, uint8_t *config, diff --git a/lib/vhost/vhost_nvme.c b/lib/vhost/vhost_nvme.c index 09c1c7f17..142325f89 100644 --- a/lib/vhost/vhost_nvme.c +++ b/lib/vhost/vhost_nvme.c @@ -1070,7 +1070,8 @@ alloc_task_pool(struct spdk_vhost_nvme_dev *nvme) * virtual NVMe controller */ static int -spdk_vhost_nvme_start_device(struct spdk_vhost_dev *vdev, void *event_ctx) +spdk_vhost_nvme_start_device(struct spdk_vhost_dev *vdev, + struct spdk_vhost_session *vsession, void *event_ctx) { struct spdk_vhost_nvme_dev *nvme = to_nvme_dev(vdev); struct spdk_vhost_nvme_ns *ns_dev; @@ -1084,8 +1085,8 @@ spdk_vhost_nvme_start_device(struct spdk_vhost_dev *vdev, void *event_ctx) return -1; } - SPDK_NOTICELOG("Start Device %u, Path %s, lcore %d\n", vdev->session->vid, - vdev->path, vdev->lcore); + SPDK_NOTICELOG("Start Device %u, Path %s, lcore %d\n", vsession->vid, + vdev->path, vsession->lcore); for (i = 0; i < nvme->num_ns; i++) { ns_dev = &nvme->ns[i]; @@ -1162,7 +1163,8 @@ destroy_device_poller_cb(void *arg) /* Disable NVMe controller */ static int -spdk_vhost_nvme_stop_device(struct spdk_vhost_dev *vdev, void *event_ctx) +spdk_vhost_nvme_stop_device(struct spdk_vhost_dev *vdev, + struct spdk_vhost_session *vsession, void *event_ctx) { struct spdk_vhost_nvme_dev *nvme = to_nvme_dev(vdev); @@ -1171,7 +1173,7 @@ spdk_vhost_nvme_stop_device(struct spdk_vhost_dev *vdev, void *event_ctx) } free_task_pool(nvme); - SPDK_NOTICELOG("Stopping Device %u, Path %s\n", vdev->session->vid, vdev->path); + SPDK_NOTICELOG("Stopping Device %u, Path %s\n", vsession->vid, vdev->path); nvme->destroy_ctx.event_ctx = event_ctx; spdk_poller_unregister(&nvme->requestq_poller); @@ -1250,8 +1252,8 @@ spdk_vhost_nvme_write_config_json(struct spdk_vhost_dev *vdev, struct spdk_json_ static const struct spdk_vhost_dev_backend spdk_vhost_nvme_device_backend = { .session_ctx_size = 0, - .start_device = spdk_vhost_nvme_start_device, - .stop_device = spdk_vhost_nvme_stop_device, + .start_session = spdk_vhost_nvme_start_device, + .stop_session = spdk_vhost_nvme_stop_device, .dump_info_json = spdk_vhost_nvme_dump_info_json, .write_config_json = spdk_vhost_nvme_write_config_json, .remove_device = spdk_vhost_nvme_dev_remove, diff --git a/lib/vhost/vhost_scsi.c b/lib/vhost/vhost_scsi.c index d6a68b2d2..af2917e52 100644 --- a/lib/vhost/vhost_scsi.c +++ b/lib/vhost/vhost_scsi.c @@ -113,8 +113,10 @@ struct spdk_vhost_scsi_task { struct spdk_vhost_virtqueue *vq; }; -static int spdk_vhost_scsi_start(struct spdk_vhost_dev *, void *); -static int spdk_vhost_scsi_stop(struct spdk_vhost_dev *, void *); +static int spdk_vhost_scsi_start(struct spdk_vhost_dev *dev, + struct spdk_vhost_session *vsession, void *); +static int spdk_vhost_scsi_stop(struct spdk_vhost_dev *, + struct spdk_vhost_session *vsession, void *); static void spdk_vhost_scsi_dump_info_json(struct spdk_vhost_dev *vdev, struct spdk_json_write_ctx *w); static void spdk_vhost_scsi_write_config_json(struct spdk_vhost_dev *vdev, @@ -125,8 +127,8 @@ const struct spdk_vhost_dev_backend spdk_vhost_scsi_device_backend = { .virtio_features = SPDK_VHOST_SCSI_FEATURES, .disabled_features = SPDK_VHOST_SCSI_DISABLED_FEATURES, .session_ctx_size = sizeof(struct spdk_vhost_scsi_session) - sizeof(struct spdk_vhost_session), - .start_device = spdk_vhost_scsi_start, - .stop_device = spdk_vhost_scsi_stop, + .start_session = spdk_vhost_scsi_start, + .stop_session = spdk_vhost_scsi_stop, .dump_info_json = spdk_vhost_scsi_dump_info_json, .write_config_json = spdk_vhost_scsi_write_config_json, .remove_device = spdk_vhost_scsi_dev_remove, @@ -915,7 +917,7 @@ spdk_vhost_scsi_session_add_tgt(struct spdk_vhost_dev *vdev, /* copy the entire device state */ svsession->scsi_dev_state[scsi_tgt_num] = svsession->svdev->scsi_dev_state[scsi_tgt_num]; - if (vdev->lcore == -1) { + if (vsession->lcore == -1) { /* All done. */ return 0; } @@ -1020,7 +1022,7 @@ spdk_vhost_scsi_session_remove_tgt(struct spdk_vhost_dev *vdev, state->removed = true; /* If the session isn't currently polled, unset the dev straight away */ - if (vdev->lcore == -1) { + if (vsession->lcore == -1) { state->dev = NULL; return 0; } @@ -1206,15 +1208,11 @@ alloc_task_pool(struct spdk_vhost_scsi_session *svsession) return 0; } -/* - * A new device is added to a data core. First the device is added to the main linked list - * and then allocated to a specific data core. - */ static int -spdk_vhost_scsi_start(struct spdk_vhost_dev *vdev, void *event_ctx) +spdk_vhost_scsi_start(struct spdk_vhost_dev *vdev, + struct spdk_vhost_session *vsession, void *event_ctx) { struct spdk_vhost_scsi_dev *svdev; - struct spdk_vhost_session *vsession = vdev->session; struct spdk_vhost_scsi_session *svsession; struct spdk_scsi_dev_vhost_state *state; uint32_t i; @@ -1254,7 +1252,7 @@ spdk_vhost_scsi_start(struct spdk_vhost_dev *vdev, void *event_ctx) spdk_scsi_dev_allocate_io_channels(state->dev); } SPDK_INFOLOG(SPDK_LOG_VHOST, "Started poller for vhost controller %s on lcore %d\n", - vdev->name, vdev->lcore); + vdev->name, vsession->lcore); svsession->requestq_poller = spdk_poller_register(vdev_worker, svsession, 0); if (vsession->virtqueue[VIRTIO_SCSI_CONTROLQ].vring.desc && @@ -1303,9 +1301,9 @@ destroy_session_poller_cb(void *arg) } static int -spdk_vhost_scsi_stop(struct spdk_vhost_dev *vdev, void *event_ctx) +spdk_vhost_scsi_stop(struct spdk_vhost_dev *vdev, + struct spdk_vhost_session *vsession, void *event_ctx) { - struct spdk_vhost_session *vsession = vdev->session; struct spdk_vhost_scsi_session *svsession; svsession = to_scsi_session(vsession); diff --git a/test/unit/lib/vhost/vhost.c/vhost_ut.c b/test/unit/lib/vhost/vhost.c/vhost_ut.c index 2a9eb73a4..ca23f80cd 100644 --- a/test/unit/lib/vhost/vhost.c/vhost_ut.c +++ b/test/unit/lib/vhost/vhost.c/vhost_ut.c @@ -77,6 +77,7 @@ spdk_app_parse_core_mask(const char *mask, struct spdk_cpuset *cpumask) DEFINE_STUB(spdk_env_get_first_core, uint32_t, (void), 0); DEFINE_STUB(spdk_env_get_next_core, uint32_t, (uint32_t prev_core), 0); +DEFINE_STUB(spdk_env_get_current_core, uint32_t, (void), 0); DEFINE_STUB_V(spdk_event_call, (struct spdk_event *event)); DEFINE_STUB(rte_vhost_get_mem_table, int, (int vid, struct rte_vhost_memory **mem), 0); DEFINE_STUB(rte_vhost_get_negotiated_features, int, (int vid, uint64_t *features), 0); @@ -150,12 +151,12 @@ start_vdev(struct spdk_vhost_dev *vdev) mem->regions[1].size = 0x400000; /* 4 MB */ mem->regions[1].host_user_addr = 0x2000000; - vdev->lcore = 0; assert(vdev->session == NULL); /* spdk_vhost_dev must be allocated on a cache line boundary. */ rc = posix_memalign((void **)&vdev->session, 64, sizeof(*vdev->session)); CU_ASSERT(rc == 0); SPDK_CU_ASSERT_FATAL(vdev->session != NULL); + vdev->session->lcore = 0; vdev->session->vid = 0; vdev->session->mem = mem; }