ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev: remove handle_no_momem from push/seq cb

Browse Source 
The IOs are never completed with NOMEM from push/sequence callbacks and
NOMEM IOs are already retried in internal callbacks, so there's no point
in calling _bdev_io_handle_no_mem().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Iecc2a41f2a394836f62d541e6235277f333f226b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17765
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
This commit is contained in:
Konrad Sztyber 2023-04-25 09:29:45 +02:00 committed by David Ko
parent 8e66d976cc
commit 62ce9dbcf6
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/bdev/bdev.c
View File

@ -1550,10 +1550,6 @@ _bdev_io_complete_push_bounce_done(void *ctx, int rc)
bdev_io_put_buf(bdev_io); bdev_io_put_buf(bdev_io);
/* Continue with IO completion flow */ /* Continue with IO completion flow */
if (spdk_unlikely(_bdev_io_handle_no_mem(bdev_io, BDEV_IO_RETRY_STATE_INVALID))) {
return;
}
bdev_io_complete(bdev_io); bdev_io_complete(bdev_io);
} }
@ -7092,10 +7088,6 @@ bdev_io_complete_sequence_cb(void *ctx, int status)
bdev_io->internal.status = SPDK_BDEV_IO_STATUS_FAILED; bdev_io->internal.status = SPDK_BDEV_IO_STATUS_FAILED;
} }
if (spdk_unlikely(_bdev_io_handle_no_mem(bdev_io, BDEV_IO_RETRY_STATE_INVALID))) {
return;
}
bdev_io_complete(bdev_io); bdev_io_complete(bdev_io);
} }