From 6289e172c45d33f53138e09b7469f82257a93a9b Mon Sep 17 00:00:00 2001 From: Konrad Sztyber Date: Tue, 11 Jan 2022 09:56:56 +0100 Subject: [PATCH] test/nvmf: run bdevperf in the foreground There's no point in running bdevperf in the background only to send a framework_wait_init. Moreover, since bdevperf is executed with a 1s timeout, there's a risk that it'll finish before that RPC is sent causing a false positive failure. Fixes #2046 Signed-off-by: Konrad Sztyber Change-Id: Icb5a8535d39954b7dfd3b4386cd008214d180bf3 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11014 Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki Reviewed-by: Dong Yi --- test/nvmf/target/host_management.sh | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test/nvmf/target/host_management.sh b/test/nvmf/target/host_management.sh index 4d35b3051..a3cb66f97 100755 --- a/test/nvmf/target/host_management.sh +++ b/test/nvmf/target/host_management.sh @@ -90,12 +90,7 @@ function nvmf_host_management() { kill -9 $perfpid || true # Run bdevperf - $rootdir/test/bdev/bdevperf/bdevperf -r /var/tmp/bdevperf.sock --json <(gen_nvmf_target_json "0") -q 64 -o 65536 -w verify -t 1 & - perfpid=$! - waitforlisten $perfpid /var/tmp/bdevperf.sock - $rpc_py -s /var/tmp/bdevperf.sock framework_wait_init - - sleep 2 + $rootdir/test/bdev/bdevperf/bdevperf -r /var/tmp/bdevperf.sock --json <(gen_nvmf_target_json "0") -q 64 -o 65536 -w verify -t 1 stoptarget }