ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmf: Remove spdk_nvmf_request_get_buffers_multi API

Browse Source 
It is not used.

Change-Id: I238c5e2b2d557063f8443ca703551e02b35ba2c7
Signed-off-by: Alexey Marchuk <alexeymar@mellanox.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7882
Community-CI: Broadcom CI
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Alexey Marchuk 2021-05-14 15:54:02 +03:00 committed by Tomasz Zawadzki
parent 019a5361a5
commit 6263457ca3
5 changed files with 6 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -11,6 +11,8 @@ of spdk_idxd_probe_cb function pointer. It should be implemented in idxd_user.c.
Added `min_cntlid` and `max_cntlid` to `nvmf_create_subsystem` to limit the controller ID range. Added `min_cntlid` and `max_cntlid` to `nvmf_create_subsystem` to limit the controller ID range.
`spdk_nvmf_request_get_buffers_multi` API is removed.
### nvme ### nvme
Added a new function `spdk_nvme_ns_cmd_copy` to submit a Simple Copy Command to a Namespace. Added a new function `spdk_nvme_ns_cmd_copy` to submit a Simple Copy Command to a Namespace.

6
include/spdk/nvmf_transport.h
View File

@ -2,7 +2,7 @@
* BSD LICENSE * BSD LICENSE
* *
* Copyright (c) Intel Corporation. All rights reserved. * Copyright (c) Intel Corporation. All rights reserved.
* Copyright (c) 2019 Mellanox Technologies LTD. All rights reserved. * Copyright (c) 2019, 2021 Mellanox Technologies LTD. All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions * modification, are permitted provided that the following conditions
@ -429,10 +429,6 @@ int spdk_nvmf_request_get_buffers(struct spdk_nvmf_request *req,
struct spdk_nvmf_transport_poll_group *group, struct spdk_nvmf_transport_poll_group *group,
struct spdk_nvmf_transport *transport, struct spdk_nvmf_transport *transport,
uint32_t length); uint32_t length);
int spdk_nvmf_request_get_buffers_multi(struct spdk_nvmf_request *req,
struct spdk_nvmf_transport_poll_group *group,
struct spdk_nvmf_transport *transport,
uint32_t *lengths, uint32_t num_lengths);
bool spdk_nvmf_request_get_dif_ctx(struct spdk_nvmf_request *req, struct spdk_dif_ctx *dif_ctx); bool spdk_nvmf_request_get_dif_ctx(struct spdk_nvmf_request *req, struct spdk_dif_ctx *dif_ctx);

4
lib/nvmf/Makefile
View File

@ -34,8 +34,8 @@
SPDK_ROOT_DIR := $(abspath $(CURDIR)/../..) SPDK_ROOT_DIR := $(abspath $(CURDIR)/../..)
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk include $(SPDK_ROOT_DIR)/mk/spdk.common.mk
SO_VER := 8 SO_VER := 9
SO_MINOR := 1 SO_MINOR := 0
C_SRCS = ctrlr.c ctrlr_discovery.c ctrlr_bdev.c \ C_SRCS = ctrlr.c ctrlr_discovery.c ctrlr_bdev.c \
subsystem.c nvmf.c nvmf_rpc.c transport.c tcp.c subsystem.c nvmf.c nvmf_rpc.c transport.c tcp.c

1
lib/nvmf/spdk_nvmf.map
View File

@ -108,7 +108,6 @@
spdk_nvmf_ctrlr_get_regs; spdk_nvmf_ctrlr_get_regs;
spdk_nvmf_request_free_buffers; spdk_nvmf_request_free_buffers;
spdk_nvmf_request_get_buffers; spdk_nvmf_request_get_buffers;
spdk_nvmf_request_get_buffers_multi;
spdk_nvmf_request_get_dif_ctx; spdk_nvmf_request_get_dif_ctx;
spdk_nvmf_request_exec_fabrics; spdk_nvmf_request_exec_fabrics;
spdk_nvmf_request_exec; spdk_nvmf_request_exec;

27
lib/nvmf/transport.c
View File

@ -2,7 +2,7 @@
* BSD LICENSE * BSD LICENSE
* *
* Copyright (c) Intel Corporation. All rights reserved. * Copyright (c) Intel Corporation. All rights reserved.
* Copyright (c) 2018-2019 Mellanox Technologies LTD. All rights reserved. * Copyright (c) 2018-2019, 2021 Mellanox Technologies LTD. All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions * modification, are permitted provided that the following conditions
@ -721,28 +721,3 @@ spdk_nvmf_request_get_buffers(struct spdk_nvmf_request *req,
return rc; return rc;
} }
int
spdk_nvmf_request_get_buffers_multi(struct spdk_nvmf_request *req,
struct spdk_nvmf_transport_poll_group *group,
struct spdk_nvmf_transport *transport,
uint32_t *lengths, uint32_t num_lengths)
{
int rc = 0;
uint32_t i;
req->iovcnt = 0;
for (i = 0; i < num_lengths; i++) {
rc = nvmf_request_get_buffers(req, group, transport, lengths[i]);
if (rc != 0) {
goto err_exit;
}
}
return 0;
err_exit:
spdk_nvmf_request_free_buffers(req, group, transport);
return rc;
}