From 61b4258c5678761c005dcb9b5e223f19dd279dcb Mon Sep 17 00:00:00 2001
From: Daniel Verkamp <daniel.verkamp@intel.com>
Date: Fri, 6 Oct 2017 16:29:31 -0700
Subject: [PATCH] test/nvmf: extend test plan for NVMe-oF target

Change-Id: Ifa6d8cc512942d35aecffd29f5b7e2a85f69f431
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/365065
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
---
 test/nvmf/test_plan.md | 76 +++++++++++++++++++++++++++++++++++++-----
 1 file changed, 67 insertions(+), 9 deletions(-)

diff --git a/test/nvmf/test_plan.md b/test/nvmf/test_plan.md
index 5167888c0..94347ef89 100644
--- a/test/nvmf/test_plan.md
+++ b/test/nvmf/test_plan.md
@@ -1,7 +1,7 @@
 # SPDK nvmf_tgt test plan
 
 ## Objective
-The purpose of these tests is to verify correct behavior of SPDK NVMeOF
+The purpose of these tests is to verify correct behavior of SPDK NVMe-oF
 feature.
 These tests are run either per-commit or as nightly tests.
 
@@ -12,13 +12,13 @@ queues and enabling RPC for further configuration via RPC calls.
 RPC calls used for dynamic configuration consist:
 - creating Malloc backend devices
 - creating Null Block backend devices
-- constructing NVMe-OF subsystems
-- deleting NVMe-OF subsystems
+- constructing NVMe-oF subsystems
+- deleting NVMe-oF subsystems
 
 ### Tests
 
-#### Test 1: NVMe-OF namespace on a Logival Volumes device
-This test configures a SPDK NVMe-OF subsystem backed by logival volume
+#### Test 1: NVMe-oF namespace on a Logical Volumes device
+This test configures a SPDK NVMe-oF subsystem backed by logical volume
 devices and uses FIO to generate I/Os that target those subsystems.
 The logical volume bdevs are backed by malloc bdevs.
 Test steps:
@@ -27,11 +27,69 @@ Test steps:
 - Step 3: Create malloc bdevs.
 - Step 4: Create logical volume stores on malloc bdevs.
 - Step 5: Create 10 logical volume bdevs on each logical volume store.
-- Step 6: Create NVMe-OF subsystems with logical volume bdev namespaces.
-- Step 7: Connect to NVMe-OF susbsystems with kernel initiator.
+- Step 6: Create NVMe-oF subsystems with logical volume bdev namespaces.
+- Step 7: Connect to NVMe-oF susbsystems with kernel initiator.
 - Step 8: Run FIO with workload parameters: blocksize=256k, iodepth=64,
 workload=randwrite; varify flag is enabled so that FIO reads and verifies
 the data written to the logical device. The run time is 10 seconds for a
 quick test an 10 minutes for longer nightly test.
-- Step 9: Disconnect kernel initiator from NVMe-OF subsystems.
-- Step 10: Delete NVMe-OF subsystems from configuration.
+- Step 9: Disconnect kernel initiator from NVMe-oF subsystems.
+- Step 10: Delete NVMe-oF subsystems from configuration.
+
+### Compatibility testing
+
+- Verify functionality of SPDK `nvmf_tgt` with Linux kernel NVMe-oF host
+  - Exercise various kernel NVMe host parameters
+    - `nr_io_queues`
+    - `queue_size`
+  - Test discovery subsystem with `nvme` CLI tool
+    - Verify that discovery service works correctly with `nvme discover`
+    - Verify that large responses work (many subsystems)
+
+### Specification compliance
+
+- NVMe base spec compliance
+  - Verify all mandatory admin commands are implemented
+    - Get Log Page
+    - Identify (including all mandatory CNS values)
+      - Identify Namespace
+      - Identify Controller
+      - Active Namespace List
+      - Allocated Namespace List
+      - Identify Allocated Namespace
+      - Attached Controller List
+      - Controller List
+    - Abort
+    - Set Features
+    - Get Features
+    - Asynchronous Event Request
+    - Keep Alive
+  - Verify all mandatory NVM command set I/O commands are implemented
+    - Flush
+    - Write
+    - Read
+  - Verify all mandatory log pages
+    - Error Information
+    - SMART / Health Information
+    - Firmware Slot Information
+  - Verify all mandatory Get/Set Features
+    - Arbitration
+    - Power Management
+    - Temperature Threshold
+    - Error Recovery
+    - Number of Queues
+    - Write Atomicity Normal
+    - Asynchronous Event Configuration
+  - Verify all implemented commands behave as required by the specification
+- Fabric command processing
+  - Verify that Connect commands with invalid parameters are failed with correct response
+    - Invalid RECFMT
+    - Invalid SQSIZE
+    - Invalid SUBNQN, HOSTNQN (too long, incorrect format, not null terminated)
+    - QID != 0 before admin queue created
+    - CNTLID != 0xFFFF (static controller mode)
+  - Verify that non-Fabric commands are only allowed in the correct states
+
+### Configuration and RPC
+
+- Verify that invalid NQNs cannot be configured via conf file or RPC