From 60bb3b3e2f65cb2845f3c5b9cf779a2abab46fdf Mon Sep 17 00:00:00 2001 From: Maciej Wawryk Date: Thu, 10 Oct 2019 11:48:41 +0200 Subject: [PATCH] test: Shellcheck - include check SC2146 Remove from shellcheck excluded SC2146: This action ignores everything before the -o. Use \( \) to group. This warning is not actually present in any of spdk/spdk scripts. Signed-off-by: Maciej Wawryk Change-Id: I62549107516853d8394fff8bcb36584df9e39ac1 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/470924 Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris Reviewed-by: Ben Walker Reviewed-by: Karol Latecki --- scripts/check_format.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/check_format.sh b/scripts/check_format.sh index eb2d4707d..24c724c7f 100755 --- a/scripts/check_format.sh +++ b/scripts/check_format.sh @@ -243,7 +243,7 @@ if hash shellcheck 2>/dev/null; then SHCK_EXCLUDE="SC1083,SC2002,SC2004,\ SC2010,SC2012,SC2013,SC2016,SC2034,SC2045,SC2046,SC2068,SC2086,SC2089,SC2090,\ SC2097,SC2098,SC2103,SC2115,SC2116,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\ -SC2129,SC2140,SC2142,SC2143,SC2145,SC2146,SC2148,SC2152,SC2153,SC2154,SC2155,\ +SC2129,SC2140,SC2142,SC2143,SC2145,SC2148,SC2152,SC2153,SC2154,SC2155,\ SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,\ SC2230" # SPDK fails some error checks which have been deprecated in later versions of shellcheck.