From 6082e7560b68141a919c4698345ae52af138af02 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Tue, 24 Jul 2018 08:32:41 +0900 Subject: [PATCH] lib/env_dpdk: pass pci whitelist and blacklist options to DPDK correctly Currently passing pci whitelist and blacklist information to DPDK is done by using single dash option -w and -b, respectively. However this didn't work as reported in the Github issue #362. Hence use two dashes option --pci-whitelist= and --pci-blacklist for pci whitelist and blacklist, respectively. In the Github issue #362, more issues are reported. These will be done in subsequent patches. Change-Id: I4e36edfce90e34577e34605d5b19658554fb2496 Signed-off-by: Shuhei Matsumoto Reviewed-on: https://review.gerrithub.io/420211 Reviewed-by: Jim Harris Reviewed-by: Changpeng Liu Reviewed-by: Ben Walker Chandler-Test-Pool: SPDK Automated Test System Tested-by: SPDK CI Jenkins --- lib/env_dpdk/init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/env_dpdk/init.c b/lib/env_dpdk/init.c index 4a274328b..888f095ed 100644 --- a/lib/env_dpdk/init.c +++ b/lib/env_dpdk/init.c @@ -274,8 +274,9 @@ spdk_build_eal_cmdline(const struct spdk_env_opts *opts) for (i = 0; i < opts->num_pci_addr; i++) { spdk_pci_addr_fmt(bdf, 32, &pci_addr[i]); - args = spdk_push_arg(args, &argcount, _sprintf_alloc("%s %s", - (opts->pci_blacklist ? "-b" : "-w"), bdf)); + args = spdk_push_arg(args, &argcount, _sprintf_alloc("%s=%s", + (opts->pci_blacklist ? "--pci-blacklist" : "--pci-whitelist"), + bdf)); if (args == NULL) { return -1; }