ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nbd: return path to /dev/nbd* in start_nbd_disk

Browse Source 
This will allow us to make the start_nbd_disk method choose an available
/dev/nbd* node automatically in an upcoming commit.

Change-Id: I3c6eb67e7e0c513212eba17139fd0cc96bf9b6dd
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/413847
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Daniel Verkamp 2018-06-05 12:31:50 -07:00 committed by Jim Harris
parent 8b158aaacd
commit 5eb33f0a5f
3 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@ -2,6 +2,11 @@
## v18.07: (Upcoming Release)
### RPC
The `start_nbd_disk` RPC method now returns the path to the kernel NBD device node
rather than always returning `true`.
### Bdev
The spdk_bdev_get_io_stat() function now returns cumulative totals instead of resetting

6
lib/nbd/nbd_rpc.c
View File

@ -88,15 +88,15 @@ spdk_rpc_start_nbd_disk(struct spdk_jsonrpc_request *request,
goto invalid;
}
free_rpc_start_nbd_disk(&req);
w = spdk_jsonrpc_begin_result(request);
if (w == NULL) {
free_rpc_start_nbd_disk(&req);
return;
}
spdk_json_write_bool(w, true);
spdk_json_write_string(w, req.nbd_device);
spdk_jsonrpc_end_result(request, w);
free_rpc_start_nbd_disk(&req);
return;
invalid:

6
scripts/rpc.py
View File

@ -764,9 +764,9 @@ if __name__ == "__main__":
# nbd
@call_cmd
def start_nbd_disk(args):
rpc.nbd.start_nbd_disk(args.client,
bdev_name=args.bdev_name,
nbd_device=args.nbd_device)
print(rpc.nbd.start_nbd_disk(args.client,
bdev_name=args.bdev_name,
nbd_device=args.nbd_device))
p = subparsers.add_parser('start_nbd_disk', help='Export a bdev as a nbd disk')
p.add_argument('bdev_name', help='Blockdev name to be exported. Example: Malloc0.')