From 5e01bdb41d4e4ef40ec99d4f66e47cc2d6b656f2 Mon Sep 17 00:00:00 2001 From: Weifeng Su Date: Wed, 11 Nov 2020 02:35:53 -0500 Subject: [PATCH] lib/event: add assert check after call spdk_reactor_get Signed-off-by: Weifeng Su Signed-off-by: Shihao Sun Change-Id: Ib2012fd57071c89743477eba26047f127e68ce4f Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5074 Reviewed-by: Changpeng Liu Reviewed-by: Shuhei Matsumoto Reviewed-by: Aleksey Marchuk Tested-by: SPDK CI Jenkins --- lib/event/reactor.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/event/reactor.c b/lib/event/reactor.c index a840168b4..b0264b70f 100644 --- a/lib/event/reactor.c +++ b/lib/event/reactor.c @@ -515,6 +515,7 @@ _reactors_scheduler_fini(void *arg1, void *arg2) SPDK_ENV_FOREACH_CORE(i) { reactor = spdk_reactor_get(i); + assert(reactor != NULL); reactor->flags.is_scheduling = false; } } @@ -528,6 +529,7 @@ _reactors_scheduler_cancel(void *arg1, void *arg2) SPDK_ENV_FOREACH_CORE(i) { reactor = spdk_reactor_get(i); + assert(reactor != NULL); reactor->flags.is_scheduling = false; } } @@ -544,6 +546,7 @@ _reactors_scheduler_gather_metrics(void *arg1, void *arg2) uint32_t i; reactor = spdk_reactor_get(spdk_env_get_current_core()); + assert(reactor != NULL); reactor->flags.is_scheduling = true; core_info = &g_core_infos[reactor->lcore]; core_info->lcore = reactor->lcore; @@ -845,7 +848,7 @@ spdk_reactors_stop(void *arg1) if (spdk_interrupt_mode_is_enabled()) { SPDK_ENV_FOREACH_CORE(i) { reactor = spdk_reactor_get(i); - + assert(reactor != NULL); rc = write(reactor->events_fd, ¬ify, sizeof(notify)); if (rc < 0) { SPDK_ERRLOG("failed to notify event queue for reactor(%u): %s.\n", i, spdk_strerror(errno));