From 5d25e3fcc8750ad9e1510e4a46e01230fecae602 Mon Sep 17 00:00:00 2001
From: Konrad Sztyber <konrad.sztyber@intel.com>
Date: Tue, 14 Mar 2023 11:01:17 +0100
Subject: [PATCH] bdev/malloc: don't retry failed requests

If a request was marked as failed, we don't want to retry it, so we
shouldn't override its status with NOMEM.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I85a522a7934d2d6f415620b9a323effefb91f299
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17196
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
---
 module/bdev/malloc/bdev_malloc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/module/bdev/malloc/bdev_malloc.c b/module/bdev/malloc/bdev_malloc.c
index 9581d9eb6..f01dbc30f 100644
--- a/module/bdev/malloc/bdev_malloc.c
+++ b/module/bdev/malloc/bdev_malloc.c
@@ -98,7 +98,9 @@ malloc_done(void *ref, int status)
 
 	if (status != 0) {
 		if (status == -ENOMEM) {
-			task->status = SPDK_BDEV_IO_STATUS_NOMEM;
+			if (task->status == SPDK_BDEV_IO_STATUS_SUCCESS) {
+				task->status = SPDK_BDEV_IO_STATUS_NOMEM;
+			}
 		} else {
 			task->status = SPDK_BDEV_IO_STATUS_FAILED;
 		}