diff --git a/test/common/lib/nvme/common_stubs.h b/test/common/lib/nvme/common_stubs.h new file mode 100644 index 000000000..8e8bc78b7 --- /dev/null +++ b/test/common/lib/nvme/common_stubs.h @@ -0,0 +1,69 @@ +/*- + * BSD LICENSE + * + * Copyright (c) Intel Corporation. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Intel Corporation nor the names of its + * contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ +#include "common/lib/test_env.c" + +const char * +spdk_nvme_transport_id_trtype_str(enum spdk_nvme_transport_type trtype) +{ + switch (trtype) { + case SPDK_NVME_TRANSPORT_PCIE: + return "PCIe"; + case SPDK_NVME_TRANSPORT_RDMA: + return "RDMA"; + case SPDK_NVME_TRANSPORT_FC: + return "FC"; + default: + return NULL; + } +} + +int +spdk_nvme_transport_id_populate_trstring(struct spdk_nvme_transport_id *trid, const char *trstring) +{ + int len, i; + + if (trstring == NULL) { + return -EINVAL; + } + + len = strnlen(trstring, SPDK_NVMF_TRSTRING_MAX_LEN); + if (len == SPDK_NVMF_TRSTRING_MAX_LEN) { + return -EINVAL; + } + + /* cast official trstring to uppercase version of input. */ + for (i = 0; i < len; i++) { + trid->trstring[i] = toupper(trstring[i]); + } + return 0; +} diff --git a/test/unit/lib/nvme/nvme_pcie.c/nvme_pcie_ut.c b/test/unit/lib/nvme/nvme_pcie.c/nvme_pcie_ut.c index c5ac8eda9..121926893 100644 --- a/test/unit/lib/nvme/nvme_pcie.c/nvme_pcie_ut.c +++ b/test/unit/lib/nvme/nvme_pcie.c/nvme_pcie_ut.c @@ -36,45 +36,9 @@ #include "spdk_cunit.h" #define UNIT_TEST_NO_VTOPHYS -#include "common/lib/test_env.c" #include "nvme/nvme_pcie.c" - -const char * -spdk_nvme_transport_id_trtype_str(enum spdk_nvme_transport_type trtype) -{ - switch (trtype) { - case SPDK_NVME_TRANSPORT_PCIE: - return "PCIe"; - case SPDK_NVME_TRANSPORT_RDMA: - return "RDMA"; - case SPDK_NVME_TRANSPORT_FC: - return "FC"; - default: - return NULL; - } -} - -int -spdk_nvme_transport_id_populate_trstring(struct spdk_nvme_transport_id *trid, const char *trstring) -{ - int len, i; - - if (trstring == NULL) { - return -EINVAL; - } - - len = strnlen(trstring, SPDK_NVMF_TRSTRING_MAX_LEN); - if (len == SPDK_NVMF_TRSTRING_MAX_LEN) { - return -EINVAL; - } - - /* cast official trstring to uppercase version of input. */ - for (i = 0; i < len; i++) { - trid->trstring[i] = toupper(trstring[i]); - } - return 0; -} +#include "common/lib/nvme/common_stubs.h" struct spdk_log_flag SPDK_LOG_NVME = { .name = "nvme", diff --git a/test/unit/lib/nvme/nvme_rdma.c/nvme_rdma_ut.c b/test/unit/lib/nvme/nvme_rdma.c/nvme_rdma_ut.c index 9154c2655..8ecca2b6d 100644 --- a/test/unit/lib/nvme/nvme_rdma.c/nvme_rdma_ut.c +++ b/test/unit/lib/nvme/nvme_rdma.c/nvme_rdma_ut.c @@ -33,8 +33,8 @@ #include "spdk/stdinc.h" #include "spdk_cunit.h" -#include "common/lib/test_env.c" #include "nvme/nvme_rdma.c" +#include "common/lib/nvme/common_stubs.h" SPDK_LOG_REGISTER_COMPONENT("nvme", SPDK_LOG_NVME) diff --git a/test/unit/lib/nvme/nvme_tcp.c/nvme_tcp_ut.c b/test/unit/lib/nvme/nvme_tcp.c/nvme_tcp_ut.c index 6efefcf29..2b33a3bec 100644 --- a/test/unit/lib/nvme/nvme_tcp.c/nvme_tcp_ut.c +++ b/test/unit/lib/nvme/nvme_tcp.c/nvme_tcp_ut.c @@ -35,10 +35,10 @@ #include "spdk_cunit.h" -#include "common/lib/test_env.c" #include "common/lib/test_sock.c" #include "nvme/nvme_tcp.c" +#include "common/lib/nvme/common_stubs.h" SPDK_LOG_REGISTER_COMPONENT("nvme", SPDK_LOG_NVME);