From 5a48cd96909fc03ed1553ece50fb0d518f317288 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Fri, 3 Apr 2020 04:10:26 -0400 Subject: [PATCH] test/ioat: verify app will exit with error code This change will make sure that verify application exits with error code 1 whenever there was no test performed. Mainly by checking work_fn return code. Other changes made to align with returning 1 on error. Signed-off-by: Tomasz Zawadzki Change-Id: I28a36dd5d5adb50bb4f54b1cc724c80da96af564 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1671 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Darek Stojaczyk --- examples/ioat/verify/verify.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/examples/ioat/verify/verify.c b/examples/ioat/verify/verify.c index 1409ad6a9..0df41f69b 100644 --- a/examples/ioat/verify/verify.c +++ b/examples/ioat/verify/verify.c @@ -328,7 +328,7 @@ work_fn(void *arg) struct thread_entry *t = (struct thread_entry *)arg; if (!t->chan) { - return 0; + return 1; } t->lcore_id = spdk_env_get_current_core(); @@ -369,7 +369,7 @@ init_src_buffer(void) g_src = spdk_dma_zmalloc(SRC_BUFFER_SIZE, 512, NULL); if (g_src == NULL) { fprintf(stderr, "Allocate src buffer failed\n"); - return -1; + return 1; } for (i = 0; i < SRC_BUFFER_SIZE / 4; i++) { @@ -504,7 +504,10 @@ main(int argc, char **argv) } threads[current_core].chan = get_next_chan(); - work_fn(&threads[current_core]); + if (work_fn(&threads[current_core]) != 0) { + rc = 1; + goto cleanup; + } spdk_env_thread_wait_all(); rc = dump_result(threads, num_threads);