From 59c5be6231cc7446641e50e60737702af9780edf Mon Sep 17 00:00:00 2001 From: Evgeniy Kochetov Date: Tue, 11 Dec 2018 19:57:21 +0000 Subject: [PATCH] nvmf: Improve error handling in spdk_nvmf_transport_poll_group_create At least in case of RDMA transport, poll_group_create (spdk_nvmf_rdma_poll_group_create) can return error (NULL). Change-Id: If1576b3515e7f9ede76af08bfa6b1c8399dcda09 Signed-off-by: Sasha Kotchubievsky Signed-off-by: Evgeniy Kochetov Reviewed-on: https://review.gerrithub.io/436887 (master) Reviewed-on: https://review.gerrithub.io/437349 Chandler-Test-Pool: SPDK Automated Test System Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Shuhei Matsumoto Reviewed-by: Ben Walker --- lib/nvmf/transport.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/nvmf/transport.c b/lib/nvmf/transport.c index af4660c96..0f1771bc7 100644 --- a/lib/nvmf/transport.c +++ b/lib/nvmf/transport.c @@ -1,8 +1,8 @@ /*- * BSD LICENSE * - * Copyright (c) Intel Corporation. - * All rights reserved. + * Copyright (c) Intel Corporation. All rights reserved. + * Copyright (c) 2018 Mellanox Technologies LTD. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -140,6 +140,9 @@ spdk_nvmf_transport_poll_group_create(struct spdk_nvmf_transport *transport) struct spdk_nvmf_transport_poll_group *group; group = transport->ops->poll_group_create(transport); + if (!group) { + return NULL; + } group->transport = transport; return group;