From 5960c74d04e33ea59419a238730db1464f98a58a Mon Sep 17 00:00:00 2001 From: Jaroslaw Chachulski Date: Thu, 2 Jun 2022 09:48:43 -0400 Subject: [PATCH] scripts/rpc: remove default values from bdev_nvme_add_error_injection Removing default options from parser command to prevent overwrite by argparse the defaults defined in the .c files. Signed-off-by: Jaroslaw Chachulski Change-Id: I757b893a65a1c0e21310171fa8b89a87e28b87a4 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12871 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber Reviewed-by: Ben Walker --- scripts/rpc.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/rpc.py b/scripts/rpc.py index 515106b4a..287892561 100755 --- a/scripts/rpc.py +++ b/scripts/rpc.py @@ -2864,10 +2864,10 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse p.add_argument('-t', '--cmd-type', help="""Type of NVMe command. Valid values are: admin, io""", required=True) p.add_argument('-o', '--opc', help="""Opcode of the NVMe command.""", required=True, type=int) p.add_argument('-s', '--do-not-submit', - help="""Set to true if request should not be submitted to the controller (default false)""", - default=False, dest="do_not_submit", action='store_true') + help="""Set to true if request should not be submitted to the controller""", + dest="do_not_submit", action='store_true') p.add_argument('-w', '--timeout-in-us', help="""Wait specified microseconds when do_not_submit is true""", type=int) - p.add_argument('-e', '--err-count', help="""Number of matching NVMe commands to inject errors (default 1)""", type=int, default=1) + p.add_argument('-e', '--err-count', help="""Number of matching NVMe commands to inject errors""", type=int) p.add_argument('-u', '--sct', help="""Status code type""", type=int) p.add_argument('-c', '--sc', help="""Status code""", type=int) p.set_defaults(func=bdev_nvme_add_error_injection)