From 592fc6f410ca188c4eae725a013a18254895db47 Mon Sep 17 00:00:00 2001 From: GangCao Date: Mon, 26 Dec 2022 02:02:37 -0500 Subject: [PATCH] examples/nvme_manage: check the valid address parse Change-Id: I40daaae514902854c5d546388789e88248fe6869 Signed-off-by: GangCao Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16078 Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Jim Harris --- examples/nvme/nvme_manage/nvme_manage.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/examples/nvme/nvme_manage/nvme_manage.c b/examples/nvme/nvme_manage/nvme_manage.c index 74267c470..196e72ed8 100644 --- a/examples/nvme/nvme_manage/nvme_manage.c +++ b/examples/nvme/nvme_manage/nvme_manage.c @@ -71,8 +71,14 @@ attach_cb(void *cb_ctx, const struct spdk_nvme_transport_id *trid, struct spdk_nvme_cmd cmd; /* add to dev list */ - dev = &devs[num_devs++]; - spdk_pci_addr_parse(&dev->pci_addr, trid->traddr); + dev = &devs[num_devs]; + if (spdk_pci_addr_parse(&dev->pci_addr, trid->traddr) != 0) { + fprintf(stderr, "spdk_pci_addr_parse failure\n"); + assert(false); + return; + } + num_devs++; + dev->ctrlr = ctrlr; /* Retrieve controller data */