ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmf: remove unused g_num_connections array

Browse Source 
The per-lcore connection counter was incremented and decremented, but it
is no longer actually read.  The lcore allocation should happen at the
session level instead.

Change-Id: I7bdf1b521bfda4892304338d43fad3ed5123c494
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2016-07-11 12:51:20 -07:00
parent 2eff92ab88
commit 58f62ad5b1
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/nvmf/conn.c
View File

@ -59,8 +59,6 @@
*/ */
static rte_atomic32_t g_num_connections[RTE_MAX_LCORE];
static int g_max_conns; static int g_max_conns;
static struct spdk_nvmf_conn *g_conns_array; static struct spdk_nvmf_conn *g_conns_array;
@ -101,7 +99,7 @@ free_conn(struct spdk_nvmf_conn *conn)
int spdk_initialize_nvmf_conns(int max_connections) int spdk_initialize_nvmf_conns(int max_connections)
{ {
int i, rc; int rc;
rc = pthread_mutex_init(&g_conns_mutex, NULL); rc = pthread_mutex_init(&g_conns_mutex, NULL);
if (rc != 0) { if (rc != 0) {
@ -112,10 +110,6 @@ int spdk_initialize_nvmf_conns(int max_connections)
g_max_conns = max_connections; g_max_conns = max_connections;
g_conns_array = calloc(g_max_conns, sizeof(struct spdk_nvmf_conn)); g_conns_array = calloc(g_max_conns, sizeof(struct spdk_nvmf_conn));
for (i = 0; i < RTE_MAX_LCORE; i++) {
rte_atomic32_set(&g_num_connections[i], 0);
}
return 0; return 0;
} }
@ -177,7 +171,6 @@ spdk_nvmf_startup_conn(struct spdk_nvmf_conn *conn)
conn->poller.fn = spdk_nvmf_conn_do_work; conn->poller.fn = spdk_nvmf_conn_do_work;
conn->poller.arg = conn; conn->poller.arg = conn;
rte_atomic32_inc(&g_num_connections[lcore]);
spdk_poller_register(&conn->poller, lcore, NULL); spdk_poller_register(&conn->poller, lcore, NULL);
return 0; return 0;
@ -220,7 +213,6 @@ static void spdk_nvmf_conn_destruct(struct spdk_nvmf_conn *conn)
event = spdk_event_allocate(rte_lcore_id(), _conn_destruct, conn, NULL, NULL); event = spdk_event_allocate(rte_lcore_id(), _conn_destruct, conn, NULL, NULL);
spdk_poller_unregister(&conn->poller, event); spdk_poller_unregister(&conn->poller, event);
rte_atomic32_dec(&g_num_connections[rte_lcore_id()]);
} }
static int static int