ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

idxd: Remove the batch_op field because it is not necessary.

Browse Source 
This batch_op field is not necessary because we can
use the comp_ctx->desc->opcode to judge whether it is related
a batched task or not.

Change-Id: Id329221ccf272c4c3bb8c1b5ec08433029a9a1f8
Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8865
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
This commit is contained in:
Ziye Yang 2021-07-21 23:20:29 +08:00 committed by Tomasz Zawadzki
parent e3410dd586
commit 585e808e06
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/idxd/idxd.c
View File

@ -329,8 +329,6 @@ _track_comp(struct spdk_idxd_io_channel *chan, bool batch_op, uint32_t index,
{ {
comp_ctx->desc = desc; comp_ctx->desc = desc;
comp_ctx->index = index; comp_ctx->index = index;
/* Tag this as a batched operation or not so we know which bit array index to clear. */
comp_ctx->batch_op = batch_op;
/* Only add non-batch completions here. Batch completions are added when the batch is /* Only add non-batch completions here. Batch completions are added when the batch is
* submitted. * submitted.
@ -1095,13 +1093,10 @@ spdk_idxd_process_events(struct spdk_idxd_io_channel *chan)
} }
comp_ctx->hw.status = status = 0; comp_ctx->hw.status = status = 0;
if (comp_ctx->desc->opcode != IDXD_OPCODE_BATCH) {
if (comp_ctx->batch_op == false) {
assert(spdk_bit_array_get(chan->ring_slots, comp_ctx->index)); assert(spdk_bit_array_get(chan->ring_slots, comp_ctx->index));
spdk_bit_array_clear(chan->ring_slots, comp_ctx->index); spdk_bit_array_clear(chan->ring_slots, comp_ctx->index);
} } else {
if (comp_ctx->desc->opcode == IDXD_OPCODE_BATCH) {
_free_batch(comp_ctx->batch, chan); _free_batch(comp_ctx->batch, chan);
} }
} else { } else {

1
lib/idxd/idxd.h
View File

@ -160,7 +160,6 @@ struct idxd_comp {
struct idxd_hw_desc *desc; struct idxd_hw_desc *desc;
uint32_t *crc_dst; uint32_t *crc_dst;
uint32_t index; uint32_t index;
bool batch_op;
char pad[3]; char pad[3];
TAILQ_ENTRY(idxd_comp) link; TAILQ_ENTRY(idxd_comp) link;
}; };