ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme: Use not C++ style comments // but C-style comments /* */

Browse Source 
Change-Id: I480a4f19d291459734ed605ba4ea8b03f1dcb713
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/431082
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Shuhei Matsumoto 2018-10-29 12:18:22 +09:00 committed by Ben Walker
parent d35ee09edf
commit 5817c68251
3 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
examples/nvme/fio_plugin/fio_plugin.c
View File

@ -101,12 +101,12 @@ struct spdk_fio_thread {
struct thread_data *td; struct thread_data *td;
struct spdk_fio_qpair *fio_qpair; struct spdk_fio_qpair *fio_qpair;
struct spdk_fio_qpair *fio_qpair_current; // the current fio_qpair to be handled. struct spdk_fio_qpair *fio_qpair_current; /* the current fio_qpair to be handled. */
struct io_u **iocq; // io completion queue struct io_u **iocq; /* io completion queue */
unsigned int iocq_count; // number of iocq entries filled by last getevents unsigned int iocq_count; /* number of iocq entries filled by last getevents */
unsigned int iocq_size; // number of iocq entries allocated unsigned int iocq_size; /* number of iocq entries allocated */
struct fio_file *current_f; // fio_file given by user struct fio_file *current_f; /* fio_file given by user */
}; };
@ -690,7 +690,7 @@ spdk_fio_queue(struct thread_data *td, struct io_u *io_u)
lba = io_u->offset / block_size; lba = io_u->offset / block_size;
lba_count = io_u->xfer_buflen / block_size; lba_count = io_u->xfer_buflen / block_size;
// TODO: considering situations that fio will randomize and verify io_u /* TODO: considering situations that fio will randomize and verify io_u */
if (fio_qpair->do_nvme_pi) { if (fio_qpair->do_nvme_pi) {
fio_extended_lba_setup_pi(fio_qpair, io_u); fio_extended_lba_setup_pi(fio_qpair, io_u);
} }

5
lib/nvme/nvme_ctrlr_ocssd_cmd.c
View File

@ -38,8 +38,9 @@ bool
spdk_nvme_ctrlr_is_ocssd_supported(struct spdk_nvme_ctrlr *ctrlr) spdk_nvme_ctrlr_is_ocssd_supported(struct spdk_nvme_ctrlr *ctrlr)
{ {
if (ctrlr->quirks & NVME_QUIRK_OCSSD) { if (ctrlr->quirks & NVME_QUIRK_OCSSD) {
// TODO: There isn't a standardized way to identify Open-Channel SSD /* TODO: There isn't a standardized way to identify Open-Channel SSD
// different verdors may have different conditions. * different verdors may have different conditions.
*/
/* /*
* Current QEMU OpenChannel Device needs to check nsdata->vs[0]. * Current QEMU OpenChannel Device needs to check nsdata->vs[0].

4
test/unit/lib/nvme/nvme_qpair.c/nvme_qpair_ut.c
View File

@ -77,14 +77,14 @@ nvme_transport_qpair_fail(struct spdk_nvme_qpair *qpair)
int int
nvme_transport_qpair_submit_request(struct spdk_nvme_qpair *qpair, struct nvme_request *req) nvme_transport_qpair_submit_request(struct spdk_nvme_qpair *qpair, struct nvme_request *req)
{ {
// TODO /* TODO */
return 0; return 0;
} }
int32_t int32_t
nvme_transport_qpair_process_completions(struct spdk_nvme_qpair *qpair, uint32_t max_completions) nvme_transport_qpair_process_completions(struct spdk_nvme_qpair *qpair, uint32_t max_completions)
{ {
// TODO /* TODO */
return 0; return 0;
} }